Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only using 'id' OR 'name' from pb path in datastore.Entity.save. #291

Merged
merged 1 commit into from
Oct 23, 2014
Merged

Only using 'id' OR 'name' from pb path in datastore.Entity.save. #291

merged 1 commit into from
Oct 23, 2014

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 23, 2014

This was introduced in #289 and discovered while rebasing those
changes into #281.

The datastore backend fails if both 'id' and 'name' are set on
a key, so this only copies the parts of the saved pb key that
are actually set.

@tseaver Please give this a look. #289 actually broke datastore when saving keys with no id/name set.

@dhermes
Only using 'id' OR 'name' from pb path in datastore.Entity.save.
6c3b983 
This was introduced in googleapis#289 and discovered while rebasing those
changes into googleapis#281.

The datastore backend fails if both 'id' and 'name' are set on
a key, so this only copies the parts of the saved pb key that
are actually set.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
c565318 
Will be removed after rebasing on top of googleapis#291.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6c3b983 on dhermes:fix-key-error-in-entity-save into 8a21978 on GoogleCloudPlatform:master.

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
930e137 
Will be removed after rebasing on top of googleapis#291.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
87012d8 
Will be removed after rebasing on top of googleapis#291.
@tseaver
Copy link
Contributor

tseaver commented Oct 23, 2014

LGTM,

dhermes added a commit that referenced this pull request Oct 23, 2014
@dhermes
Merge pull request #291 from dhermes/fix-key-error-in-entity-save
b6d3e74 
Only using 'id' OR 'name' from pb path in datastore.Entity.save.
@dhermes dhermes merged commit b6d3e74 into googleapis:master Oct 23, 2014
@dhermes dhermes deleted the fix-key-error-in-entity-save branch October 23, 2014 23:05
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
feat: add result_end_time to SpeechRecognitionResult (#291)
c74dcd2 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413728495

Source-Link: googleapis/googleapis@10f96cb

Source-Link: googleapis/googleapis-gen@f464864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ2NDg2NDI5MmViNmIwNTVmMWUxZDg0MDhhZmY4NzgxN2NjYTY0YyJ9

docs: add clarification for global and regional endpoints
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
feat: add result_end_time to SpeechRecognitionResult (#291)
5a0e352 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413728495

Source-Link: googleapis/googleapis@10f96cb

Source-Link: googleapis/googleapis-gen@f464864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ2NDg2NDI5MmViNmIwNTVmMWUxZDg0MDhhZmY4NzgxN2NjYTY0YyJ9

docs: add clarification for global and regional endpoints
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
feat: add result_end_time to SpeechRecognitionResult (#291)
edad4b5 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413728495

Source-Link: googleapis/googleapis@10f96cb

Source-Link: googleapis/googleapis-gen@f464864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ2NDg2NDI5MmViNmIwNTVmMWUxZDg0MDhhZmY4NzgxN2NjYTY0YyJ9

docs: add clarification for global and regional endpoints
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
feat: add result_end_time to SpeechRecognitionResult (#291)
6cfd048 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413728495

Source-Link: googleapis/googleapis@10f96cb

Source-Link: googleapis/googleapis-gen@f464864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ2NDg2NDI5MmViNmIwNTVmMWUxZDg0MDhhZmY4NzgxN2NjYTY0YyJ9

docs: add clarification for global and regional endpoints
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
feat: enable "rest" transport in Python for services supporting numer…
c934825 
…ic enums (#291)

* feat: enable "rest" transport in Python for services supporting numeric enums

PiperOrigin-RevId: 508143576

Source-Link: googleapis/googleapis@7a702a9

Source-Link: googleapis/googleapis-gen@6ad1279
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.0 (#291)
3f49f0c
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): exclude grpcio==1.49.0rc1 in tests [autoapprove] (#291)
7ceeb35 
Source-Link: googleapis/synthtool@c4dd595
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
feat: add api key support (#291)
af50bb1 
* chore: upgrade gapic-generator-java, gax-java and gapic-generator-python

PiperOrigin-RevId: 423842556

Source-Link: googleapis/googleapis@a616ca0

Source-Link: googleapis/googleapis-gen@29b938c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjliOTM4YzU4YzFlNTFkMDE5ZjJlZTUzOWQ1NWRjMGEzYzg2YTkwNSJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): drop flake8-import-order in samples noxfile (#291)
6b62f3c 
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: use gapic generator python 1.4.1 (#291)
2e31f9a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9
parthea added a commit that referenced this pull request Jun 4, 2023
@release-please @parthea
chore(main): release 2.11.0 (#291)
fdcb218 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@renovate-bot
chore(deps): update dependency google-api-python-client to v2.43.0 (#291
0b5f256 
)
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
chore(python): allow client documentation to be customized in README (#…
e047fbd 
…291)

Source-Link: googleapis/synthtool@95d9289
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c8878270182edaab99f2927969d4f700c3af265accd472c3425deedff2b7fd93

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-video-transcoder to v1.8.0 (
87d1e6f 
#291)
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@parthea
chore: Update Owl bot begin-after-commit-hash (#291)
8119f18 
PR #290 included changes to the generated client but the conventional commit messages were not included in the PR. This PR updates the `begin-after-commit-hash` that owl-bot uses to pull changes from googleapis-gen to match [this commit](https://github.com/googleapis/googleapis-gen/search?q=0a3c7d272d697796db75857bac73905c68e498c3&type=commits).

The following changes are already in master:

feat: added more Environment RPCs
feat: added Versions service
feat: added Fulfillment service
feat: added TextToSpeechSettings.
feat: added location in some resource patterns
fix: removed incorrect resource annotation for UpdateEnvironmentRequest.
fix: add async client to %name_%version/init.py
chore: add autogenerated snippets
chore: remove auth, policy, and options from the reserved names list
feat: support self-signed JWT flow for service accounts
chore: enable GAPIC metadata generation
chore: sort subpackages in %namespace/%name/init.py
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#291)
31874e8 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(deps): update actions/setup-python action to v4 [autoapprove] (#…
65b9494 
…291)

Source-Link: googleapis/synthtool@8e55b32
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.3 (#291)
f1ccae6
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
feat: Add support for dataproc BatchController service (#291)
7fcb2d5 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 404333740

Source-Link: googleapis/googleapis@5088bd7

Source-Link: googleapis/googleapis-gen@44b8707
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRiODcwNzgzYzE5NDM3NzFiY2RlYzc0OGFlNGQ1MjA4YzNkN2YwZSJ9
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore: release 3.1.0 (#288)
a7130a8 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.1.0](https://www.github.com/googleapis/python-dataproc/compare/v3.0.0...v3.1.0) (2021-10-26)


### Features

* add context manager support in client ([#285](https://www.github.com/googleapis/python-dataproc/issues/285)) ([b54fb76](https://www.github.com/googleapis/python-dataproc/commit/b54fb7647deaea64fe6ad553514c9d0ad62a0cbc))
* add Dataproc Serverless for Spark Batches API ([#290](https://www.github.com/googleapis/python-dataproc/issues/290)) ([f0ed26c](https://www.github.com/googleapis/python-dataproc/commit/f0ed26c6ccd2e9f438d1d5f31c5512761b0e20b9))
* Add support for dataproc BatchController service ([#291](https://www.github.com/googleapis/python-dataproc/issues/291)) ([24a6f7d](https://www.github.com/googleapis/python-dataproc/commit/24a6f7defee1e0fd2d195f934c004769d8f1a2b7))
* add support for python 3.10 ([#289](https://www.github.com/googleapis/python-dataproc/issues/289)) ([229f919](https://www.github.com/googleapis/python-dataproc/commit/229f919e31c39bc028cd2e6062437b0a8d061556))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
chore(python): run blacken session for all directories with a noxfile (…
3f5401d 
…#291)

* chore(python): run blacken session for all directories with a noxfile

Source-Link: googleapis/synthtool@bc0de6e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39ad8c0570e4f5d2d3124a509de4fe975e799e2b97e0f58aed88f8880d5a8b60

* lint

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: [autoapprove] Pin flake8 version (#291)
8d6d951 
Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
fix(deps): allow protobuf 3.19.5 (#291)
8156748 
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-tasks to v2.10.2 (#291)
b931abf
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#291)
6c886f4 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.1.1 (#291)
9820ae4
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: blacken samples noxfile template (#291)
c91c135
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
feat: add audience parameter (#291)
41fdeee 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 456827138

Source-Link: googleapis/googleapis@23f1a15

Source-Link: googleapis/googleapis-gen@4075a85
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDA3NWE4NTE0ZjY3NjY5MWVjMTU2Njg4YTViYmYxODNhYTk4OTNjZSJ9

feat: Update Compute Engine API to revision 20220526 (#722)
Source-Link: googleapis/googleapis@950dd73

Source-Link: googleapis/googleapis-gen@57ace17
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTdhY2UxNzhjODU0M2M0NDYyNzgyMzA0NTkxNzgyMGQ2N2I0OTBjMSJ9

fix(deps): require google-api-core 2.8.0
parthea added a commit that referenced this pull request Oct 21, 2023
@dandhlee @parthea
docs: fix changelog header to consistent size (#291)
073bc6b 
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update all dependencies (#291)
6ec177e
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
chore: regenerate samples (#291)
f39bd37 
* feat: Add client library support for AssetService v1 SavedQuery APIs
Committer: jeffreyai@

PiperOrigin-RevId: 475366952

Source-Link: googleapis/googleapis@7428dad

Source-Link: googleapis/googleapis-gen@5629e2a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTYyOWUyYWI3Mjg0NDNhMWE2YWJiMDNmMzRmOTI1ZDVjZDRlMGM0NyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update gapic-generator-python to 1.4.3 with test fixes

PiperOrigin-RevId: 475399737

Source-Link: googleapis/googleapis@4c4a9a2

Source-Link: googleapis/googleapis-gen@72fdb5a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJmZGI1YWU1NWE0ZDY1ODM4OTNhM2U1N2I3ZWYyNjQ4NTBkMDZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v1.43.0 (#291)
df85f3f
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: rename rst files to avoid conflict with service names (#291)
85f9a4e 
Source-Link: googleapis/synthtool@d52e638
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
feat: add result_end_time to SpeechRecognitionResult (#291)
69be6a9 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 413728495

Source-Link: googleapis/googleapis@10f96cb

Source-Link: googleapis/googleapis-gen@f464864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjQ2NDg2NDI5MmViNmIwNTVmMWUxZDg0MDhhZmY4NzgxN2NjYTY0YyJ9

docs: add clarification for global and regional endpoints
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
docs: Add documentation for enums (#291)
9190738 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @coveralls @tseaver