Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #260: break datastore cycles by moving 'from_protobuf' classmethods #289

Merged
merged 5 commits into from
Oct 23, 2014
Merged

Fix #260: break datastore cycles by moving 'from_protobuf' classmethods #289

merged 5 commits into from
Oct 23, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 23, 2014

Third time's the charm for #260 in datastore:

'gcloud.datastore._helpers' -> 'gcloud.datastore.helpers' (now API).

'gcloud.datastore.entity.Entity.from_protobuf' classmethod -> 'gcloud.datastore.helpers.entity_from_protobuf'.

'gcloud.datastore.key.Key.from_protobuf' classmethod -> 'gcloud.datastore.helpers.key_from_protobuf'.

@tseaver
Rename datastore._helpers -> helpers.
949df73 
We are going to move 'Entity.from_protobuf' and 'Key.from_protobuf' into
the module as free functions, which will be APIs:  this module needs not
to signal that it has no APIs.

Document now-API module 'gcloud.datastore.helpers'.
@tseaver
Fix #260: remove import cycles in datastore.
d1e1dd3 
'entity.Entity.from_protobuf' classmethod -> 'helpers.entity_from_protobuf'.

'key.Key.from_protobuf' classmethod -> 'helpers.key_from_protobuf'.
@tseaver
Enforce cycle checking.
f330550
@tseaver
Update 'gcloud.datastore.helpers' to indicate API-ness.
a00e00e 
Correct docstring.

Add '__all__' to indicate public members.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a00e00e on tseaver:260-break_datastore_cycles_move_from_protobuf into 09859db on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Oct 23, 2014
View reviewed changes
gcloud/datastore/entity.py
@@ -248,9 +222,11 @@ def save(self):
transaction.add_auto_id_entity(self)

if isinstance(key_pb, datastore_pb.Key):
updated_key = Key.from_protobuf(key_pb)
path = [
{'kind': x.kind, 'id': x.id, 'name': x.name}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2014

Great work! LGTM pending the small change above.

I'm really happy we landed here, I really applaud the thought that went into the process from #268 to #288 to this.

@dhermes
Copy link
Contributor

dhermes commented Oct 23, 2014

Thanks for making the change. Feel free to merge after Travis passes.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 15cd8a2 on tseaver:260-break_datastore_cycles_move_from_protobuf into 09859db on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Oct 23, 2014
@tseaver
Merge pull request #289 from tseaver/260-break_datastore_cycles_move_…
8a21978 
…from_protobuf

Fix #260: break datastore cycles by moving 'from_protobuf' classmethods
@tseaver tseaver merged commit 8a21978 into googleapis:master Oct 23, 2014
@tseaver tseaver deleted the 260-break_datastore_cycles_move_from_protobuf branch October 23, 2014 19:51
@dhermes dhermes mentioned this pull request Oct 23, 2014
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Only using 'id' OR 'name' from pb path in datastore.Entity.save.
6c3b983 
This was introduced in googleapis#289 and discovered while rebasing those
changes into googleapis#281.

The datastore backend fails if both 'id' and 'name' are set on
a key, so this only copies the parts of the saved pb key that
are actually set.
@dhermes dhermes mentioned this pull request Oct 23, 2014
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
c565318 
Will be removed after rebasing on top of googleapis#291.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
930e137 
Will be removed after rebasing on top of googleapis#291.
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Oct 23, 2014
@dhermes
Temp commit to fix breakage from googleapis#289.
87012d8 
Will be removed after rebasing on top of googleapis#291.
@dhermes dhermes added api: datastore Issues related to the Datastore API. hygiene labels Dec 31, 2015
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#289)
9b3f112 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@galz10
chore: updated pypi link in readme (#289)
9cfde14 
* chore: updated pypi link in readme

* updated links
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
ci(python): run lint / unit tests / docs as GH actions (#289)
404b2d5 
* ci(python): run lint / unit tests / docs as GH actions

Source-Link: googleapis/synthtool@57be0cd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6

* add commit to trigger gh actions

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
ci(python): fix path to requirements.txt in release script (#289)
b994778 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): update release script dependencies [autoapprove] (#289)
011ba74 
Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore: Bump gapic-generator-python version to 1.3.0 (#289)
146404a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: googleapis/googleapis-gen@4313d68
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
parthea added a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot @parthea
feat: Add BigQuery export APIs (#289)
4b0fa8a 
* feat: Add BigQuery export APIs that help you enable writing new/updated findings from  Security Command Center to a BigQuery table in near-real time. You can then integrate the data into existing workflows and create custom analyses. You can enable this feature at the organization, folder, and project levels to export findings based on your requirements

PiperOrigin-RevId: 431905699

Source-Link: googleapis/googleapis@4c1b56f

Source-Link: googleapis/googleapis-gen@fbaf35c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmJhZjM1YzZjZDdmODE3ZjU3MjI4OWVkMGY4YTMzODEyYTZlYjNiOSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@gcf-owl-bot
chore(python): refactor unit / system test dependency install (#289)
083483d 
Source-Link: googleapis/synthtool@993985f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd
parthea added a commit that referenced this pull request Sep 20, 2023
@kchertenko @parthea
chore(samples): fix product name and remove time params. (#289)
4887648 
* fix: fix product name and remove time params.

* fix linter

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Sep 20, 2023
@release-please @parthea
chore(main): release 1.8.0 (#289)
649ab65 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: fix prerelease_deps nox session [autoapprove] (#289)
138d2f1 
Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790
parthea added a commit that referenced this pull request Sep 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#289)
b89c835 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this pull request Sep 22, 2023
@parthea
feat: add support for python 3.10 (#289)
7fa49b8
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore: release 3.1.0 (#288)
a7130a8 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.1.0](https://www.github.com/googleapis/python-dataproc/compare/v3.0.0...v3.1.0) (2021-10-26)


### Features

* add context manager support in client ([#285](https://www.github.com/googleapis/python-dataproc/issues/285)) ([b54fb76](https://www.github.com/googleapis/python-dataproc/commit/b54fb7647deaea64fe6ad553514c9d0ad62a0cbc))
* add Dataproc Serverless for Spark Batches API ([#290](https://www.github.com/googleapis/python-dataproc/issues/290)) ([f0ed26c](https://www.github.com/googleapis/python-dataproc/commit/f0ed26c6ccd2e9f438d1d5f31c5512761b0e20b9))
* Add support for dataproc BatchController service ([#291](https://www.github.com/googleapis/python-dataproc/issues/291)) ([24a6f7d](https://www.github.com/googleapis/python-dataproc/commit/24a6f7defee1e0fd2d195f934c004769d8f1a2b7))
* add support for python 3.10 ([#289](https://www.github.com/googleapis/python-dataproc/issues/289)) ([229f919](https://www.github.com/googleapis/python-dataproc/commit/229f919e31c39bc028cd2e6062437b0a8d061556))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.56.2 (#289)
239c387 
* chore: update Java and Python dependencies

PiperOrigin-RevId: 408420890

Source-Link: googleapis/googleapis@2921f9f

Source-Link: googleapis/googleapis-gen@6598ca8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.7.2 (#289)
d77c8f1 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.10.2 (#289)
a6802ce 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.65.2 (#289)
e14993d 
* chore: use gapic-generator-python 0.65.2

PiperOrigin-RevId: 444333013

Source-Link: googleapis/googleapis@f91b6cf

Source-Link: googleapis/googleapis-gen@16eb360
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-storage to v2.2.0 (#289)
1e37a0a
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-asset to v3.5.0 (#289)
923e909 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-asset](https://togithub.com/googleapis/python-asset) | `==3.4.0` -> `==3.5.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-asset/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-asset/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-asset/3.5.0/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-asset/3.5.0/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-asset</summary>

### [`v3.5.0`](https://togithub.com/googleapis/python-asset/blob/master/CHANGELOG.md#&#8203;350-httpswwwgithubcomgoogleapispython-assetcomparev340v350-2021-09-03)

[Compare Source](https://togithub.com/googleapis/python-asset/compare/v3.4.0...v3.5.0)

##### Features

-   add inventory_path ([#&#8203;283](https://www.togithub.com/googleapis/python-asset/issues/283)) ([fbb47e6](https://www.github.com/googleapis/python-asset/commit/fbb47e6487fe454ca84d2415cf756a87bf66739f))
-   **v1:** Add content type Relationship to support relationship search ([038febe](https://www.github.com/googleapis/python-asset/commit/038febe4c21d6ece23872e01cffc1110c59d6699))
-   **v1:** add relationships ([#&#8203;281](https://www.togithub.com/googleapis/python-asset/issues/281)) ([038febe](https://www.github.com/googleapis/python-asset/commit/038febe4c21d6ece23872e01cffc1110c59d6699))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-asset).
parthea added a commit that referenced this pull request Oct 21, 2023
@release-please @parthea
chore(main): release 1.3.2 (#289)
ebea322 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 1.0.0 (#289)
1a2a49a 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 451250442

Source-Link: googleapis/googleapis@cca5e81

Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/download-artifact action to v3 (#289)
2ec7bc3 
Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.53.4 (#289)
8245793 
- [ ] Regenerate this pull request now.

docs: list oneofs in docstring
fix(deps): require google-api-core >= 1.28.0
fix(deps): drop packaging dependency

committer: busunkim96@
PiperOrigin-RevId: 406468269

Source-Link: googleapis/googleapis@83d81b0

Source-Link: googleapis/googleapis-gen@2ff001f
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9
parthea added a commit that referenced this pull request Oct 21, 2023
@ikuleshov @parthea @gcf-owl-bot
docs: add a sample for runAccessReport method (#289)
660971d 
* update test configuration

* remove custom noxfile configs for now

* remove MaximumUserAccess rom sample

* add comment in noxfile_config.py

* run blacken session

* lint

* add pytest

* Update noxfile_config.py

* Update noxfile_config.py

* delete enhanced measurement settings samples as this functionality is no longer supported in v1alpha

* fix the samples tests

* do not use the `maximum_user_access` field and `update` operation in properties.firebase_links tests as this is no longer supported in v1alpha

* use `creator_email_address` instead of `email_address` field in properties.google_ads_links_list() test as the field has been renamed in v1alpha

* fix the samples test

* add a sample for runAccessReport method

* add a sample for runAccessReport method

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix the test

* fix the test

Co-authored-by: Anthonios Partheniou <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-auth-oauthlib to v0.5.3 (#289)
51810b0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@kweinmeister @gcf-owl-bot
docs: Updated tables_client docstring (#289)
2ce1e96 
* Updated tables_client docstring

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Addressed review feedback

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore: [autoapprove] Update black and isort to latest versions (#289
e0b97e6 
)

Source-Link: https://togithub.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547
parthea pushed a commit that referenced this pull request Oct 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-trace to v1.9.0 (#289)
2038260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @coveralls @dhermes