fix(dns): update test assertion and core version pins #10096

plamut · 2020-01-10T15:51:36Z

Towards #10088.

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Version bump is needed, as timeouts were introduced to API core.

plamut added 2 commits January 10, 2020 15:47

Adjust request params assertion in test (timeout)

4ae92d9

Update version pin for core dependency

8649dbd

Version bump is needed, as timeouts were introduced to API core.

plamut added the api: dns Issues related to the Cloud DNS API. label Jan 10, 2020

plamut requested a review from busunkim96 as a code owner January 10, 2020 15:51

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020

busunkim96 approved these changes Jan 10, 2020

View reviewed changes

plamut merged commit 561dced into googleapis:master Jan 10, 2020

plamut deleted the fix-tests-dns branch January 10, 2020 17:57

Provide feedback