Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust unit tests to account for the new connection timeout parameter #10088

Closed
plamut opened this issue Jan 10, 2020 · 1 comment
Closed

Adjust unit tests to account for the new connection timeout parameter #10088

plamut opened this issue Jan 10, 2020 · 1 comment
Assignees
@plamut
Labels
api: cloudresourcemanager Issues related to the Resource Manager API. api: dns Issues related to the Cloud DNS API. api: logging Issues related to the Cloud Logging API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: translation Issues related to the Cloud Translation API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@plamut
Copy link
Contributor

plamut commented Jan 10, 2020 •
edited
Loading

The google-cloud-core release v1.1.0 introduced a new optional timeout parameter to the JSONConnection object.

The timeout is passed down to the transport layer, which breaks several assertions in unit tests across different libraries, thus the assertions need to be adjusted.

Additionally, the version pins of the core dependencies need to be bumped in order to assure that core connections that support timeouts are always used.

Update:
Looking at #10094, security center, spanner, and storage fail for other reasons, thus their respective labels are not applied.
@plamut plamut added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 10, 2020
@plamut plamut self-assigned this Jan 10, 2020
@plamut plamut added the api: logging Issues related to the Cloud Logging API. label Jan 10, 2020
This was referenced Jan 10, 2020
Merged
Closed
@plamut plamut added api: cloudresourcemanager Issues related to the Resource Manager API. api: translation Issues related to the Cloud Translation API API. api: dns Issues related to the Cloud DNS API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. labels Jan 10, 2020
This was referenced Jan 10, 2020
Merged
Merged
Merged
Merged
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jan 15, 2020
@plamut
Copy link
Contributor Author

plamut commented Jan 16, 2020

The most recent test suite run in #10094 showed that the previously failing tests of the libraries in question now pass after all the fixes. Closing.

@plamut plamut closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: cloudresourcemanager Issues related to the Resource Manager API. api: dns Issues related to the Cloud DNS API. api: logging Issues related to the Cloud Logging API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: translation Issues related to the Cloud Translation API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plamut @yoshi-automation