PubSub: Message publish_time return type unexpected

[alexcwatt]

I am working on a PubSub project and was a bit confused about the Message publish_time. I expected to get datetime per the docstring for the method. Instead I got a Timestamp that apparently comes from protobuf types. I found there is even a unit test that verifies that publish_time returns a Timestamp.

Can we return datetime? Or should the docs just be updated to explain what is actually being returned? I'd prefer the former but wanted to ask before submitting a PR, given the inconsistency.

[tseaver]

@alexcwatt Thanks for the report! I believe that updating the implementation / test to convert the integer timestamp to a date time is best.

[tseaver]

@theacodes I marked this as triaged for GA because the return type of the publish_time method property needs to change to match the docstring: ISTM that is a "surface" change which we might want to fix before GA.

[tseaver]

@theacodes Hmm, apparently I misunderstood the triaged for GA label: I think this issue should be fixed before GA.

[tseaver]

@alexcwatt If you don't already have a PR in hand, I'm going to go ahead this week, so that we can get the change in place before the upcoming GA release.

[alexcwatt]

@tseaver Awesome, thanks!