Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubsub: Make 'Message.publish_time' return datetime #5633

Merged
merged 2 commits into from
Jul 17, 2018
Merged

Pubsub: Make 'Message.publish_time' return datetime #5633

merged 2 commits into from
Jul 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 16, 2018

Closes #5598

tseaver added 2 commits July 16, 2018 17:04
@tseaver
Use named constants for timestamps.
c2e7318 
Derive from known datetime.
@tseaver
Make 'Message.publish_time' return a datetime.
9d4ab5f 
Rather than a 'google.protobuf.timestamp_pb2.Timestamp' instance.

Closes #5598.
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Jul 16, 2018
@tseaver tseaver requested review from tswast and theacodes July 16, 2018 21:39
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2018
tswast
tswast reviewed Jul 16, 2018
View reviewed changes
pubsub/google/cloud/pubsub_v1/subscriber/message.py
timestamp = self._message.publish_time
delta = datetime.timedelta(
seconds=timestamp.seconds,
microseconds=timestamp.nanos // 1000)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 861d51a into master Jul 17, 2018
@tseaver tseaver deleted the 5598-pubsub-message-publish_time-as-datetime branch July 17, 2018 20:14
@descent3me descent3me mentioned this pull request Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast left review comments

@theacodes theacodes Awaiting requested review from theacodes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @tswast @googlebot