Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt split repo: _python-assured-workloads_ #10902

Closed
vchudnov-g opened this issue Apr 4, 2023 · 3 comments
Closed

Adopt split repo: _python-assured-workloads_ #10902

vchudnov-g opened this issue Apr 4, 2023 · 3 comments
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds

Comments

@vchudnov-g
Copy link
Contributor

vchudnov-g commented Apr 4, 2023 •
edited
Loading

Migrate the split-repo https://github.com/googleapis/python-assured-workloads to https://github.com/googleapis/google-cloud-python.

The migration readiness criteria are the following, which we track via GitHub labels on this issue. These criteria apply to the split repo we are migrating from:

  • No open issues
  • No open PRs
  • No handwritten samples
  • No system tests
  • No client-specific customizations
@vchudnov-g vchudnov-g added migration:samples:generated Split repo to be migrated here has generated samples migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:library:gapic_auto Library type of the split repo to be migrated here migration:testing:unit Split repo to be migrated here has unit tests migration:issues:none Split repo to be migrated here had no open issues when last checked labels Apr 4, 2023
@vchudnov-g vchudnov-g changed the title Adopt split repo: python-assured-workloads Adopt split repo: _python-assured-workloads_ Apr 6, 2023
@vchudnov-g vchudnov-g added the migration:pr:none Split repo to be migrated has no pending PRs label Apr 6, 2023
@parthea
Copy link
Contributor

parthea commented Apr 11, 2023

Opened googleapis/python-assured-workloads#241 to remove the obsolete replacement in owlbot.py

@vchudnov-g vchudnov-g added migration:pr:pending Split repo to be migrated has pending PRs and removed migration:pr:none Split repo to be migrated has no pending PRs labels Apr 12, 2023
@parthea parthea added the migration:needs:generatorchanges Need generator changes + regeneration to resolve blockers. Please describe changes needed. label Apr 14, 2023
@parthea
Copy link
Contributor

parthea commented Apr 14, 2023

Wait for googleapis/gapic-generator-python#1645 and googleapis/gapic-generator-python#1646

@parthea
Copy link
Contributor

parthea commented Aug 14, 2023

Ready to migrate once googleapis/python-assured-workloads#241 is merged

@parthea parthea added migration:ready migration:pr:none Split repo to be migrated has no pending PRs migration:workaround:none Split repo to be migrated here has no manual workarounds and removed migration:workaround:owlbot Split repo to be migrated here has owlbot workarounds migration:pr:pending Split repo to be migrated has pending PRs migration:needs:generatorchanges Need generator changes + regeneration to resolve blockers. Please describe changes needed. labels Aug 15, 2023
This was referenced Sep 14, 2023
Merged
Merged
parthea added a commit that referenced this issue Sep 14, 2023
@parthea
chore(migration): Migrate code from googleapis/python-assured-workloa…
6e5c862 
…ds into packages/google-cloud-assured-workloads (#11644)

See #10902. 

This PR should be merged with a merge-commit, not a squash-commit, in
order to preserve the git history.
@parthea parthea added migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. labels Sep 14, 2023
@parthea parthea closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
migration:issues:none Split repo to be migrated here had no open issues when last checked migration:library:gapic_auto Library type of the split repo to be migrated here migration:pr:none Split repo to be migrated has no pending PRs migration:ready migration:samples:generated Split repo to be migrated here has generated samples migration:stage:common-files-updated Migration stage finished: central monorepo files changed ("post-process" PR submitted) migration:stage:git-history-merged Migration stage finished: finished merging githistory (PR submitted) migration:stage:split-repo-archived Migration stage finished: the split repo has been archived. migration:stage:split-repo-trimmed Migration stage finished: the split repo has been pared down (PR submitted) migration:testing:unit Split repo to be migrated here has unit tests migration:workaround:none Split repo to be migrated here has no manual workarounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parthea @vchudnov-g