Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove REST methods for rpcs which do not have http annotations #1645

Merged
merged 3 commits into from
Apr 14, 2023
Merged

fix: remove REST methods for rpcs which do not have http annotations #1645

merged 3 commits into from
Apr 14, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Apr 13, 2023

Towards #1644

@parthea parthea marked this pull request as ready for review April 13, 2023 14:42
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 13, 2023
@parthea parthea requested review from a team as code owners April 13, 2023 14:42
@parthea parthea changed the title chore: exclude __REQUIRED_FIELDS_DEFAULT_VALUES for rpcs without http annotations chore: remove REST methods for rpcs which do not have http annotations Apr 13, 2023
@parthea parthea changed the title chore: remove REST methods for rpcs which do not have http annotations fix: remove REST methods for rpcs which do not have http annotations Apr 13, 2023
@parthea parthea mentioned this pull request Apr 13, 2023
Merged
@parthea parthea mentioned this pull request Apr 14, 2023
Closed
vchudnov-g
vchudnov-g approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you mention this PR in internal issue 262044440?

@parthea
Copy link
Contributor Author

parthea commented Apr 14, 2023

Done

@parthea parthea merged commit 2419ada into main Apr 14, 2023
@parthea parthea deleted the exclude-rest-code branch April 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees

@vchudnov-g vchudnov-g

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthea @vchudnov-g