Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gcs-conformance): add test for downloadAsStream retry headers #6072

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Apr 14, 2023

This is for the review of #5637

There was previously no coverage for the changes made to StorageObject::downloadAsStream to ensure the range headers were retried as expected

@bshaffer bshaffer requested review from a team as code owners April 14, 2023 20:27
$this->retryListener,
[$exception, $retryAttempt, $arguments]
[$exception, $retryAttempt, &$arguments]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified this because a "listener" should not be expected to return a request and arguments. The ability to modify the request/arguments should be optional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we did this change after the conversation about removing the call by ref arguments :)
Do you wanna go back the old route?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do we change the name to something more appropriate thing like modifyRequestFunction()?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a conversation of this PR, but I'm not too convinced on the name retryListener anyway.
There is a retryFunction already present, and now we're adding a listener?
The difference isn't exactly clear.

Copy link
Contributor

@saranshdhingra saranshdhingra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small confusion about reverting to modifying arguments inside the retryListener. Except for that LGTM.

@saranshdhingra
Copy link
Contributor

saranshdhingra commented Apr 18, 2023

I think these changes are all present in #6073 , so closing this.

@bshaffer bshaffer deleted the gcs-conformance-add-stream-headers-test branch April 18, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants