-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gcs-conformance): add test for downloadAsStream retry headers #6072
chore(gcs-conformance): add test for downloadAsStream retry headers #6072
Conversation
$this->retryListener, | ||
[$exception, $retryAttempt, $arguments] | ||
[$exception, $retryAttempt, &$arguments] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified this because a "listener" should not be expected to return a request and arguments. The ability to modify the request/arguments should be optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we did this change after the conversation about removing the call by ref arguments :)
Do you wanna go back the old route?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do we change the name to something more appropriate thing like modifyRequestFunction()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a conversation of this PR, but I'm not too convinced on the name retryListener
anyway.
There is a retryFunction
already present, and now we're adding a listener?
The difference isn't exactly clear.
526f31c
to
eafcc24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small confusion about reverting to modifying arguments inside the retryListener
. Except for that LGTM.
I think these changes are all present in #6073 , so closing this. |
This is for the review of #5637
There was previously no coverage for the changes made to
StorageObject::downloadAsStream
to ensure the range headers were retried as expected