-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Storage): Add retry conformance tests #5637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saranshdhingra
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 21, 2022
product-auto-label
bot
added
the
api: storage
Issues related to the Cloud Storage API.
label
Nov 21, 2022
saranshdhingra
force-pushed
the
gcs-conformance-testing
branch
from
November 21, 2022 15:56
4b5c963
to
5665dd7
Compare
shivgautam
reviewed
Nov 21, 2022
saranshdhingra
force-pushed
the
gcs-conformance-testing
branch
from
November 24, 2022 16:09
0a3f883
to
07620aa
Compare
saranshdhingra
changed the title
feat(Storage): Add retry conformance tests for idempotent ops
feat(Storage): Add retry conformance tests
Nov 29, 2022
bshaffer
reviewed
Dec 21, 2022
* feat(Storage): Add retry decider function for GCS --------- Co-authored-by: Yash Sahu <[email protected]> Co-authored-by: Saransh Dhingra <[email protected]> Co-authored-by: Vishwaraj Anand <[email protected]> Co-authored-by: Brent Shaffer <[email protected]> Co-authored-by: David Supplee <[email protected]> Co-authored-by: David Supplee <[email protected]>
* Added github workflow to run gcs retry tests
* Added unit tests for onExecutionStartFunction --------- Co-authored-by: Saransh Dhingra <[email protected]>
…is/google-cloud-php into gcs-conformance-testing
bshaffer
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit regarding dependencies, and a handful of changes to improve the unit tests.
saranshdhingra
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Apr 19, 2023
bshaffer
approved these changes
Apr 20, 2023
bshaffer
force-pushed
the
gcs-conformance-testing
branch
from
April 24, 2023 13:24
1cee476
to
686223c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
next release
PRs to be included in the next release
release blocking
Required feature/issue must be fixed prior to next release.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(Storage): add contextual retries (#5637)
END_COMMIT_OVERRIDE