Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Storage): Add retry conformance tests #5637

Merged
merged 55 commits into from
Apr 25, 2023
Merged

Conversation

saranshdhingra
Copy link
Contributor

@saranshdhingra saranshdhingra commented Nov 21, 2022

BEGIN_COMMIT_OVERRIDE
feat(Storage): add contextual retries (#5637)
END_COMMIT_OVERRIDE

@saranshdhingra saranshdhingra added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 21, 2022
@saranshdhingra saranshdhingra requested review from a team as code owners November 21, 2022 12:58
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 21, 2022
@saranshdhingra saranshdhingra force-pushed the gcs-conformance-testing branch from 4b5c963 to 5665dd7 Compare November 21, 2022 15:56
@saranshdhingra saranshdhingra force-pushed the gcs-conformance-testing branch from 0a3f883 to 07620aa Compare November 24, 2022 16:09
@saranshdhingra saranshdhingra changed the title feat(Storage): Add retry conformance tests for idempotent ops feat(Storage): Add retry conformance tests Nov 29, 2022
ajupazhamayil and others added 6 commits March 1, 2023 01:30
* feat(Storage): Add retry decider function for GCS

---------

Co-authored-by: Yash Sahu <[email protected]>
Co-authored-by: Saransh Dhingra <[email protected]>
Co-authored-by: Vishwaraj Anand <[email protected]>
Co-authored-by: Brent Shaffer <[email protected]>
Co-authored-by: David Supplee <[email protected]>
Co-authored-by: David Supplee <[email protected]>
* Added github workflow to run gcs retry tests
* Added unit tests for onExecutionStartFunction
---------

Co-authored-by: Saransh Dhingra <[email protected]>
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit regarding dependencies, and a handful of changes to improve the unit tests.

Storage/composer.json Outdated Show resolved Hide resolved
Storage/tests/Unit/Connection/RestTest.php Outdated Show resolved Hide resolved
Storage/tests/Unit/Connection/RestTest.php Outdated Show resolved Hide resolved
Core/tests/Unit/Upload/ResumableUploaderTest.php Outdated Show resolved Hide resolved
Core/tests/Unit/RequestWrapperTest.php Outdated Show resolved Hide resolved
Core/src/Upload/AbstractUploader.php Outdated Show resolved Hide resolved
@saranshdhingra saranshdhingra removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2023
@saranshdhingra saranshdhingra requested a review from bshaffer April 19, 2023 12:16
Storage/tests/Unit/StorageObjectTest.php Outdated Show resolved Hide resolved
Storage/tests/Unit/Connection/RestTest.php Outdated Show resolved Hide resolved
@bshaffer bshaffer force-pushed the gcs-conformance-testing branch from 1cee476 to 686223c Compare April 24, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. next release PRs to be included in the next release release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants