Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix doc generator #2409

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Conversation

dwsupplee
Copy link
Contributor

It looks like we don't always need to append the projectRoot, it is already included with calls to getFileName.

@dwsupplee dwsupplee added the type: docs Improvement to the documentation for an API. label Oct 14, 2019
@dwsupplee dwsupplee requested a review from jdpedrie October 14, 2019 20:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2019
@dwsupplee dwsupplee changed the title fix: Fix doc generator fix: fix doc generator Oct 14, 2019
@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #2409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2409   +/-   ##
=========================================
  Coverage     92.55%   92.55%           
  Complexity     4504     4504           
=========================================
  Files           312      312           
  Lines         13496    13496           
=========================================
  Hits          12491    12491           
  Misses         1005     1005

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3c025...fa2d268. Read the comment docs.

@dwsupplee dwsupplee merged commit fbb01fc into googleapis:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants