fix: Fix doc generator (#2409)

googleapis · Oct 14, 2019 · fbb01fc · fbb01fc
1 parent 862fb9c
commit fbb01fc
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/dev/src/DocGenerator/Parser/CodeParser.php b/dev/src/DocGenerator/Parser/CodeParser.php
@@ -844,6 +844,7 @@ private function getExternalDepVersion($type, $external)
     private function buildInternalLink($content)
     {
         $componentId = null;
+        $content = trim($content, '\\');
         $ref = $this->getClassReference($content);
         $fileName = $ref->getFileName();
 
@@ -852,7 +853,6 @@ private function buildInternalLink($content)
             $componentId = $composer['extra']['component']['id'];
         }
 
-        $content = trim($content, '\\');
         $parts = explode('::', $content);
         $type = $this->fileNameToType($fileName);
 
@@ -960,27 +960,25 @@ private function getClassReference($type)
         // third party dependencies require type hints and throw a Parse error
         // when an implementation is not compatible with its parent class or
         // interface.
-        static $map = [
+        $unreflectableMap = [
             // Monolog 1.x/2.x related classes
             'Google\Cloud\Core\Logger\AppEngineFlexFormatter' => 'Core/src/Logger/AppEngineFlexFormatter.php',
             'Google\Cloud\Core\Logger\AppEngineFlexFormatterV2' => 'Core/src/Logger/AppEngineFlexFormatterV2.php',
             'Google\Cloud\Core\Logger\AppEngineFlexHandler' => 'Core/src/Logger/AppEngineFlexHandler.php',
             'Google\Cloud\Core\Logger\AppEngineFlexHandlerV2' => 'Core/src/Logger/AppEngineFlexHandlerV2.php',
         ];
+        static $reflectedMap = [];
 
-        if (array_key_exists($type, $map)) {
-            return new ClassReference($type, $this->projectRoot.'/'.$map[$type]);
-        }
-
-        foreach ($map as $key => $value) {
-            if (strpos($type, $key) !== false) {
-                return new ClassReference($type, $this->projectRoot.'/'.$value);
-            }
+        if (array_key_exists($type, $unreflectableMap)) {
+            return new ClassReference($type, $this->projectRoot . $unreflectableMap[$type]);
+        } elseif (array_key_exists($type, $reflectedMap)) {
+            return new ClassReference($type, $reflectedMap[$type]);
         }
 
-        $map[$type] = $this->getReflectionClass($type)->getFileName();
+        $reflectedMap[$type] = $this->getReflectionClass($type)
+            ->getFileName();
 
-        return new ClassReference($type, $this->projectRoot.'/'.$map[$type]);
+        return new ClassReference($type, $reflectedMap[$type]);
     }
 
     private function getReflectionClass($type)