Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: prevent maxInProgress from being sent to the API #992

Merged
merged 1 commit into from
Dec 6, 2015
Merged

pubsub: prevent maxInProgress from being sent to the API #992

merged 1 commit into from
Dec 6, 2015

Conversation

stephenplusplus
Copy link
Contributor

Fixes #985

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: pubsub Issues related to the Pub/Sub API. labels Dec 4, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2015
@stephenplusplus
Copy link
Contributor Author

@leibale can you give this a shot?

$ npm install --save stephenplusplus/gcloud-node#spp--pubsub-985

@leibale
Copy link
Contributor

leibale commented Dec 6, 2015

you fixed the #985 bug, but breaking something else (it might not be you, but it does not matter).. :(
at line 471 in pubsub/index.js you should use resp.name || subName (if the status is 409 and reuseExisting is true i got The name of a subscription is required. error).

stephenplusplus added a commit that referenced this pull request Dec 6, 2015
@stephenplusplus
Merge pull request #992 from stephenplusplus/spp--pubsub-985
f540309 
pubsub: prevent maxInProgress from being sent to the API
@stephenplusplus stephenplusplus merged commit f540309 into googleapis:master Dec 6, 2015
@stephenplusplus
Copy link
Contributor Author

That's definitely a new bug, thanks for catching that. Opening a new issue now. (PR welcome as always :))

@stephenplusplus stephenplusplus mentioned this pull request Dec 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephenplusplus @leibale @googlebot