Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant subscribe with maxInProgress option #985

Closed
leibale opened this issue Dec 2, 2015 · 4 comments
Closed

cant subscribe with maxInProgress option #985

leibale opened this issue Dec 2, 2015 · 4 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API.

Comments

@leibale
Copy link
Contributor

leibale commented Dec 2, 2015

it's return ApiError to callback

Invalid JSON payload received. Unknown name "max_in_progress": Cannot find field.
@stephenplusplus
Copy link
Contributor

Where is that field hiding? I'll find it unless @callmehiphop beats me to it.

@leibale
Copy link
Contributor Author

leibale commented Dec 3, 2015

@callmehiphop
Copy link
Contributor

I wasn't able to reproduce this locally - @leibale would you mind sharing some example code to help reproduce this error? I believe maxInProgress is a convenience option for the client only, so I'm a little confused on how it's getting sent to the upstream API.

@callmehiphop callmehiphop added the api: pubsub Issues related to the Pub/Sub API. label Dec 3, 2015
@leibale
Copy link
Contributor Author

leibale commented Dec 3, 2015

when you create a subscription you can set the interval and stuff like this, but you can't set the maximum of messages your worker will work in parallel.
at version 24 (I think) wee (I create a pull request) add option to set the
maxInProgress and the subscription not pull more messages if your worker not call to message.ack or message.skip (this functions do -- to the counter and check if there is more messages).

I'm sorry for the English..

sofisl added a commit that referenced this issue Jan 24, 2023
* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: update README to point to migrated samples location

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove resources for migrated samples

* chore: remove samples testing

* chore: remove samples testing

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: revert removal of quickstart.js as it's used by the library

* chore: revert removal of samples tests as it's still used by the library

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: revert removing samples tests

* delete all other samples tests

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sofia Leon <[email protected]>
sofisl added a commit that referenced this issue Jan 25, 2023
* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: update README to point to migrated samples location

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove migrated samples

* chore: remove resources for migrated samples

* chore: remove samples testing

* chore: remove samples testing

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: revert removal of quickstart.js as it's used by the library

* chore: revert removal of samples tests as it's still used by the library

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: revert removing samples tests

* delete all other samples tests

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Sofia Leon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

No branches or pull requests

3 participants