-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null checks to fromPb in BucketInfo and BlobInfo, updated tests #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 28, 2015
.etag(storageObject.getEtag()) | ||
.id(storageObject.getId()) | ||
.selfLink(storageObject.getSelfLink()); | ||
Builder builder = new Builder().bucket(storageObject.getBucket()).name(storageObject.getName()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
aozarov
added a commit
that referenced
this pull request
Sep 28, 2015
Add null checks to fromPb in BucketInfo and BlobInfo, updated tests
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
🤖 I have created a release *beep* *boop* --- ## [1.2.1](googleapis/java-resource-settings@v1.2.0...v1.2.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#183](googleapis/java-resource-settings#183)) ([eb6829a](googleapis/java-resource-settings@eb6829a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
🤖 I have created a release *beep* *boop* --- ## [1.2.1](googleapis/java-network-management@v1.2.0...v1.2.1) (2022-06-23) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#183](googleapis/java-network-management#183)) ([abd025e](googleapis/java-network-management@abd025e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…#185) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/2c593734-539a-435d-8a04-27f04c90082f/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@c4f3059 Source-Link: googleapis/synthtool@6eb80fa Source-Link: googleapis/synthtool@6d3eed6 Source-Link: googleapis/synthtool@d1addcd
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…onnect to v2.2.1 (googleapis#185) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-apigee-connect](https://togithub.com/googleapis/java-apigee-connect) | `2.2.0` -> `2.2.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.2.1/compatibility-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-apigee-connect/2.2.1/confidence-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-apigee-connect).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b5715173-fa09-4f29-8c69-530ae787b970/targets - [ ] To automatically regenerate this PR, check this box. PiperOrigin-RevId: 356341083 Source-Link: googleapis/googleapis@8d8c008
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [0.2.0](https://www.github.com/googleapis/java-workflows/compare/v0.1.4...v0.2.0) (2021-02-22) ### Features * migrate to microgenerator ([#159](https://www.github.com/googleapis/java-workflows/issues/159)) ([e1b02ec](https://www.github.com/googleapis/java-workflows/commit/e1b02ec868a5b3b4f6768d756f21a5622e49c5c7)) ### Bug Fixes * update repo name ([#182](https://www.github.com/googleapis/java-workflows/issues/182)) ([e8de9cf](https://www.github.com/googleapis/java-workflows/commit/e8de9cfc5a4dcd6e8e47a45c76a2539ec35bfd6d)) ### Documentation * generate sample code in the Java microgenerator ([#185](https://www.github.com/googleapis/java-workflows/issues/185)) ([f075046](https://www.github.com/googleapis/java-workflows/commit/f075046a61e7af785e9fe216976616a14baa14bd)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.16.0 ([#151](https://www.github.com/googleapis/java-workflows/issues/151)) ([5b050ee](https://www.github.com/googleapis/java-workflows/commit/5b050ee48d0a03eb6627aa5d8d1da29c00aecbdd)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.16.1 ([3927788](https://www.github.com/googleapis/java-workflows/commit/3927788e36805e6ab016e9211991930ee195c35b)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.17.0 ([#166](https://www.github.com/googleapis/java-workflows/issues/166)) ([7bbc64a](https://www.github.com/googleapis/java-workflows/commit/7bbc64a627ad67187c2eec79209b09fa43fc0ce1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([#171](https://www.github.com/googleapis/java-workflows/issues/171)) ([2b16cc3](https://www.github.com/googleapis/java-workflows/commit/2b16cc3cb024e7bed09e3bd3a7bc7ae5611b9643)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([#193](https://www.github.com/googleapis/java-workflows/issues/193)) ([96fe1c3](https://www.github.com/googleapis/java-workflows/commit/96fe1c3d7afe3acb8444e5c695b92c5e27790971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [0.7.0](googleapis/java-dataflow@v0.6.1...v0.7.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#182](googleapis/java-dataflow#182)) ([ed93b83](googleapis/java-dataflow@ed93b83)) ### Documentation * corrected the Dataflow job name regex ([googleapis#190](googleapis/java-dataflow#190)) ([8926a78](googleapis/java-dataflow@8926a78)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/java-service-control@v1.2.0...v1.3.0) (2022-07-01) ### Features * Add Java REST transport to analytics, servicecontrol, servicemanagement, serviceusage and langauge APIs ([627df71](googleapis/java-service-control@627df71)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#186](googleapis/java-service-control#186)) ([4fc9a1d](googleapis/java-service-control@4fc9a1d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
…am to v1.1.0 (#185) * chore(deps): update dependency com.google.cloud:google-cloud-datastream to v1.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
* ci: removing clirr from required checks * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…plugin to v3 (#185) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-network-security). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.8.2` -> `==2.10.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.1/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam-admin). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMiIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4yIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](https://togithub.com/googleapis/java-iam-admin/compare/v1.2.5...v1.3.0) (2022-10-03) ### Features * Replace java_outer_classname option with use_java_stubby_library, add DisableServiceAccountKey and EnableServiceAccountKey, and update comments ([#170](https://togithub.com/googleapis/java-iam-admin/issues/170)) ([386ba5b](https://togithub.com/googleapis/java-iam-admin/commit/386ba5bd33426db7c55c3f98e8d66c783ec74960)) ### Dependencies * Update dependency cachetools to v5 ([#177](https://togithub.com/googleapis/java-iam-admin/issues/177)) ([1d5a92c](https://togithub.com/googleapis/java-iam-admin/commit/1d5a92c16f7db96b0acfe3269722c8cce0fa152d)) * Update dependency certifi to v2022.9.24 ([#179](https://togithub.com/googleapis/java-iam-admin/issues/179)) ([684c965](https://togithub.com/googleapis/java-iam-admin/commit/684c9651aadde9ba3acb7d74e5419db8b51f02b8)) * Update dependency charset-normalizer to v2.1.1 ([#183](https://togithub.com/googleapis/java-iam-admin/issues/183)) ([5956e73](https://togithub.com/googleapis/java-iam-admin/commit/5956e735c2ecc299874461b2ddb43e9528367abc)) * Update dependency click to v8.1.3 ([#184](https://togithub.com/googleapis/java-iam-admin/issues/184)) ([40cc131](https://togithub.com/googleapis/java-iam-admin/commit/40cc131e938274c97a17ca4dbb8adcbe27f453e1)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#199](https://togithub.com/googleapis/java-iam-admin/issues/199)) ([4aa7e10](https://togithub.com/googleapis/java-iam-admin/commit/4aa7e108032e665dcfea448fc6003a646db11729)) * Update dependency gcp-releasetool to v1.8.8 ([#180](https://togithub.com/googleapis/java-iam-admin/issues/180)) ([f56d6f6](https://togithub.com/googleapis/java-iam-admin/commit/f56d6f6d76119195f0bc0676b5695549bedf7e50)) * Update dependency google-api-core to v2.10.1 ([#185](https://togithub.com/googleapis/java-iam-admin/issues/185)) ([578739a](https://togithub.com/googleapis/java-iam-admin/commit/578739afb6f847d386d4d68405ca4c515b77071d)) * Update dependency google-auth to v2.12.0 ([#192](https://togithub.com/googleapis/java-iam-admin/issues/192)) ([1c420d3](https://togithub.com/googleapis/java-iam-admin/commit/1c420d3d1c279a463f4022e70e246e3e32faa75c)) * Update dependency google-cloud-core to v2.3.2 ([#181](https://togithub.com/googleapis/java-iam-admin/issues/181)) ([9d7b22b](https://togithub.com/googleapis/java-iam-admin/commit/9d7b22b4df2087462fcb3aa4ec6fb6714d53fc05)) * Update dependency google-cloud-storage to v2.5.0 ([#193](https://togithub.com/googleapis/java-iam-admin/issues/193)) ([dc53938](https://togithub.com/googleapis/java-iam-admin/commit/dc53938acc6b7f10aa18bb167f58a391d8ca2648)) * Update dependency google-crc32c to v1.5.0 ([#194](https://togithub.com/googleapis/java-iam-admin/issues/194)) ([7ee8030](https://togithub.com/googleapis/java-iam-admin/commit/7ee8030e1b58d22a31169b6bda5104d3a3357845)) * Update dependency googleapis-common-protos to v1.56.4 ([#182](https://togithub.com/googleapis/java-iam-admin/issues/182)) ([807bad5](https://togithub.com/googleapis/java-iam-admin/commit/807bad5c28f7db0c01352d4fa14a59d9ba902be1)) * Update dependency importlib-metadata to v4.12.0 ([#195](https://togithub.com/googleapis/java-iam-admin/issues/195)) ([7484838](https://togithub.com/googleapis/java-iam-admin/commit/74848383e6963616b66307cbd88dbea184a53f7d)) * Update dependency jeepney to v0.8.0 ([#196](https://togithub.com/googleapis/java-iam-admin/issues/196)) ([3107d4e](https://togithub.com/googleapis/java-iam-admin/commit/3107d4e5f8de9af01054468313c7b4895afaf50d)) * Update dependency jinja2 to v3.1.2 ([#186](https://togithub.com/googleapis/java-iam-admin/issues/186)) ([f4df361](https://togithub.com/googleapis/java-iam-admin/commit/f4df361293289b537411b0ab08029ba4a30987cc)) * Update dependency keyring to v23.9.3 ([#187](https://togithub.com/googleapis/java-iam-admin/issues/187)) ([40b4f56](https://togithub.com/googleapis/java-iam-admin/commit/40b4f56b07e7559658f844ffc8377e784795b47e)) * Update dependency markupsafe to v2.1.1 ([#188](https://togithub.com/googleapis/java-iam-admin/issues/188)) ([9c9ae27](https://togithub.com/googleapis/java-iam-admin/commit/9c9ae27377c89b99a6bea53911627c41b08a743a)) * Update dependency protobuf to v3.20.2 ([#189](https://togithub.com/googleapis/java-iam-admin/issues/189)) ([f0eef4e](https://togithub.com/googleapis/java-iam-admin/commit/f0eef4ef48092d5a9ec3fff73f052395a43deb77)) * Update dependency protobuf to v4 ([#178](https://togithub.com/googleapis/java-iam-admin/issues/178)) ([6eb4f64](https://togithub.com/googleapis/java-iam-admin/commit/6eb4f6416a3a8a562e1edb38355ea0cd5759d696)) * Update dependency pyjwt to v2.5.0 ([#190](https://togithub.com/googleapis/java-iam-admin/issues/190)) ([67b346f](https://togithub.com/googleapis/java-iam-admin/commit/67b346ffd690b3a9e57168c6fa3918e5bdf3922e)) * Update dependency requests to v2.28.1 ([#191](https://togithub.com/googleapis/java-iam-admin/issues/191)) ([8302051](https://togithub.com/googleapis/java-iam-admin/commit/8302051194f258db4e3c422212e02bb536072e0b)) * Update dependency typing-extensions to v4.3.0 ([#175](https://togithub.com/googleapis/java-iam-admin/issues/175)) ([0382f2c](https://togithub.com/googleapis/java-iam-admin/commit/0382f2ccb08606b620b2f02451efecc94bec0030)) * Update dependency zipp to v3.8.1 ([#176](https://togithub.com/googleapis/java-iam-admin/issues/176)) ([e576413](https://togithub.com/googleapis/java-iam-admin/commit/e576413a97523349f01584b3d546baf64bf20456)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: storage
Issues related to the Cloud Storage API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #184.