-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IllegalArgumentException when OPTIONS in cors #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 24, 2015
@@ -20,5 +20,5 @@ | |||
* Http method supported by Storage service. | |||
*/ | |||
public enum HttpMethod { | |||
GET, HEAD, PUT, POST, DELETE | |||
GET, HEAD, PUT, POST, DELETE, OPTIONS |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
aozarov
added a commit
that referenced
this pull request
Sep 24, 2015
Fix IllegalArgumentException when OPTIONS in cors
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
…onfig to v1.5.0 (#178) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/compatibility-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.0/confidence-slim/1.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0) ##### Features - add build scripts for native image testing in Java 17 ([#​1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#​475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a)) - to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09)) ##### Dependencies - update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-apigee-connect).
github-actions bot
pushed a commit
that referenced
this pull request
Jun 23, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
….0 (googleapis#178) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `5.5.0` -> `5.7.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-resourcemanager).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
…oogleapis#178) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 457524730 Source-Link: googleapis/googleapis@917e7f2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](googleapis/java-datastream@v1.0.0...v1.1.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#176](googleapis/java-datastream#176)) ([abf2500](googleapis/java-datastream@abf2500)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#178](googleapis/java-datastream#178)) ([4e41c2a](googleapis/java-datastream@4e41c2a)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#175](googleapis/java-datastream#175)) ([c8faa93](googleapis/java-datastream@c8faa93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/java-data-fusion@v1.2.1...v1.3.0) (2022-06-30) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#178](googleapis/java-data-fusion#178)) ([c851f67](googleapis/java-data-fusion@c851f67)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#184](googleapis/java-data-fusion#184)) ([c2b8ebf](googleapis/java-data-fusion@c2b8ebf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…security to v0.5.1 (#178) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-network-security](https://togithub.com/googleapis/java-network-security) | `0.5.0` -> `0.5.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-network-security/0.5.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-network-security/0.5.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-network-security/0.5.1/compatibility-slim/0.5.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-network-security/0.5.1/confidence-slim/0.5.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-network-security).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.7](https://togithub.com/googleapis/java-deploy/compare/v1.1.6...v1.1.7) (2022-10-03) ### Dependencies * Update dependency certifi to v2022.9.24 ([#167](https://togithub.com/googleapis/java-deploy/issues/167)) ([829bf37](https://togithub.com/googleapis/java-deploy/commit/829bf37cb0aa03b8533cd67815a34f61c17d3526)) * Update dependency charset-normalizer to v2.1.1 ([#172](https://togithub.com/googleapis/java-deploy/issues/172)) ([4384f86](https://togithub.com/googleapis/java-deploy/commit/4384f86bab95d6ca92665f38cbe1f0eba07246e6)) * Update dependency click to v8.1.3 ([#173](https://togithub.com/googleapis/java-deploy/issues/173)) ([6330f0f](https://togithub.com/googleapis/java-deploy/commit/6330f0f79535e798287797a4ba3fdcf67ff08fcb)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#188](https://togithub.com/googleapis/java-deploy/issues/188)) ([04183a8](https://togithub.com/googleapis/java-deploy/commit/04183a80c3c0c5ca711831683cf90f835af833ae)) * Update dependency gcp-releasetool to v1.8.8 ([#168](https://togithub.com/googleapis/java-deploy/issues/168)) ([3b8fa48](https://togithub.com/googleapis/java-deploy/commit/3b8fa480774fce03c6d692ba7acb5d9884dfd163)) * Update dependency google-api-core to v2.10.1 ([#174](https://togithub.com/googleapis/java-deploy/issues/174)) ([9631b06](https://togithub.com/googleapis/java-deploy/commit/9631b06317b18ec92030f534f065a722e2f4bc3b)) * Update dependency google-auth to v2.11.1 ([#169](https://togithub.com/googleapis/java-deploy/issues/169)) ([d059772](https://togithub.com/googleapis/java-deploy/commit/d0597727fb4df93e34558dc9d3d889a0bf6cdfd6)) * Update dependency google-cloud-core to v2.3.2 ([#170](https://togithub.com/googleapis/java-deploy/issues/170)) ([c9ce18c](https://togithub.com/googleapis/java-deploy/commit/c9ce18cd60c968d4fd5d78fb6e798fda22ca891e)) * Update dependency google-cloud-storage to v2.5.0 ([#175](https://togithub.com/googleapis/java-deploy/issues/175)) ([7258e5c](https://togithub.com/googleapis/java-deploy/commit/7258e5ceaeb60f67a17d597fe0fa24bea28a56f7)) * Update dependency google-crc32c to v1.5.0 ([#176](https://togithub.com/googleapis/java-deploy/issues/176)) ([41f6b20](https://togithub.com/googleapis/java-deploy/commit/41f6b20a67820a90f24af40f724710c1f30c9621)) * Update dependency googleapis-common-protos to v1.56.4 ([#171](https://togithub.com/googleapis/java-deploy/issues/171)) ([15f6e3b](https://togithub.com/googleapis/java-deploy/commit/15f6e3bec2261ead4cd0486d33d549d18b5d8c4b)) * Update dependency importlib-metadata to v4.12.0 ([#177](https://togithub.com/googleapis/java-deploy/issues/177)) ([2d69170](https://togithub.com/googleapis/java-deploy/commit/2d691702d957c2aa5ed7f18b941970a410f1feec)) * Update dependency markupsafe to v2.1.1 ([#178](https://togithub.com/googleapis/java-deploy/issues/178)) ([48e29ef](https://togithub.com/googleapis/java-deploy/commit/48e29efbf0fd29b66d5b282dca7245832d7e847b)) * Update dependency protobuf to v3.20.2 ([#179](https://togithub.com/googleapis/java-deploy/issues/179)) ([10265fc](https://togithub.com/googleapis/java-deploy/commit/10265fca9c2291f90a07ed0c296b56632c685fa5)) * Update dependency pyjwt to v2.5.0 ([#180](https://togithub.com/googleapis/java-deploy/issues/180)) ([2dab9fa](https://togithub.com/googleapis/java-deploy/commit/2dab9fa5ca31952563312a59e0cddea26a9ef7b0)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.0](https://togithub.com/googleapis/java-iam-admin/compare/v1.2.5...v1.3.0) (2022-10-03) ### Features * Replace java_outer_classname option with use_java_stubby_library, add DisableServiceAccountKey and EnableServiceAccountKey, and update comments ([#170](https://togithub.com/googleapis/java-iam-admin/issues/170)) ([386ba5b](https://togithub.com/googleapis/java-iam-admin/commit/386ba5bd33426db7c55c3f98e8d66c783ec74960)) ### Dependencies * Update dependency cachetools to v5 ([#177](https://togithub.com/googleapis/java-iam-admin/issues/177)) ([1d5a92c](https://togithub.com/googleapis/java-iam-admin/commit/1d5a92c16f7db96b0acfe3269722c8cce0fa152d)) * Update dependency certifi to v2022.9.24 ([#179](https://togithub.com/googleapis/java-iam-admin/issues/179)) ([684c965](https://togithub.com/googleapis/java-iam-admin/commit/684c9651aadde9ba3acb7d74e5419db8b51f02b8)) * Update dependency charset-normalizer to v2.1.1 ([#183](https://togithub.com/googleapis/java-iam-admin/issues/183)) ([5956e73](https://togithub.com/googleapis/java-iam-admin/commit/5956e735c2ecc299874461b2ddb43e9528367abc)) * Update dependency click to v8.1.3 ([#184](https://togithub.com/googleapis/java-iam-admin/issues/184)) ([40cc131](https://togithub.com/googleapis/java-iam-admin/commit/40cc131e938274c97a17ca4dbb8adcbe27f453e1)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#199](https://togithub.com/googleapis/java-iam-admin/issues/199)) ([4aa7e10](https://togithub.com/googleapis/java-iam-admin/commit/4aa7e108032e665dcfea448fc6003a646db11729)) * Update dependency gcp-releasetool to v1.8.8 ([#180](https://togithub.com/googleapis/java-iam-admin/issues/180)) ([f56d6f6](https://togithub.com/googleapis/java-iam-admin/commit/f56d6f6d76119195f0bc0676b5695549bedf7e50)) * Update dependency google-api-core to v2.10.1 ([#185](https://togithub.com/googleapis/java-iam-admin/issues/185)) ([578739a](https://togithub.com/googleapis/java-iam-admin/commit/578739afb6f847d386d4d68405ca4c515b77071d)) * Update dependency google-auth to v2.12.0 ([#192](https://togithub.com/googleapis/java-iam-admin/issues/192)) ([1c420d3](https://togithub.com/googleapis/java-iam-admin/commit/1c420d3d1c279a463f4022e70e246e3e32faa75c)) * Update dependency google-cloud-core to v2.3.2 ([#181](https://togithub.com/googleapis/java-iam-admin/issues/181)) ([9d7b22b](https://togithub.com/googleapis/java-iam-admin/commit/9d7b22b4df2087462fcb3aa4ec6fb6714d53fc05)) * Update dependency google-cloud-storage to v2.5.0 ([#193](https://togithub.com/googleapis/java-iam-admin/issues/193)) ([dc53938](https://togithub.com/googleapis/java-iam-admin/commit/dc53938acc6b7f10aa18bb167f58a391d8ca2648)) * Update dependency google-crc32c to v1.5.0 ([#194](https://togithub.com/googleapis/java-iam-admin/issues/194)) ([7ee8030](https://togithub.com/googleapis/java-iam-admin/commit/7ee8030e1b58d22a31169b6bda5104d3a3357845)) * Update dependency googleapis-common-protos to v1.56.4 ([#182](https://togithub.com/googleapis/java-iam-admin/issues/182)) ([807bad5](https://togithub.com/googleapis/java-iam-admin/commit/807bad5c28f7db0c01352d4fa14a59d9ba902be1)) * Update dependency importlib-metadata to v4.12.0 ([#195](https://togithub.com/googleapis/java-iam-admin/issues/195)) ([7484838](https://togithub.com/googleapis/java-iam-admin/commit/74848383e6963616b66307cbd88dbea184a53f7d)) * Update dependency jeepney to v0.8.0 ([#196](https://togithub.com/googleapis/java-iam-admin/issues/196)) ([3107d4e](https://togithub.com/googleapis/java-iam-admin/commit/3107d4e5f8de9af01054468313c7b4895afaf50d)) * Update dependency jinja2 to v3.1.2 ([#186](https://togithub.com/googleapis/java-iam-admin/issues/186)) ([f4df361](https://togithub.com/googleapis/java-iam-admin/commit/f4df361293289b537411b0ab08029ba4a30987cc)) * Update dependency keyring to v23.9.3 ([#187](https://togithub.com/googleapis/java-iam-admin/issues/187)) ([40b4f56](https://togithub.com/googleapis/java-iam-admin/commit/40b4f56b07e7559658f844ffc8377e784795b47e)) * Update dependency markupsafe to v2.1.1 ([#188](https://togithub.com/googleapis/java-iam-admin/issues/188)) ([9c9ae27](https://togithub.com/googleapis/java-iam-admin/commit/9c9ae27377c89b99a6bea53911627c41b08a743a)) * Update dependency protobuf to v3.20.2 ([#189](https://togithub.com/googleapis/java-iam-admin/issues/189)) ([f0eef4e](https://togithub.com/googleapis/java-iam-admin/commit/f0eef4ef48092d5a9ec3fff73f052395a43deb77)) * Update dependency protobuf to v4 ([#178](https://togithub.com/googleapis/java-iam-admin/issues/178)) ([6eb4f64](https://togithub.com/googleapis/java-iam-admin/commit/6eb4f6416a3a8a562e1edb38355ea0cd5759d696)) * Update dependency pyjwt to v2.5.0 ([#190](https://togithub.com/googleapis/java-iam-admin/issues/190)) ([67b346f](https://togithub.com/googleapis/java-iam-admin/commit/67b346ffd690b3a9e57168c6fa3918e5bdf3922e)) * Update dependency requests to v2.28.1 ([#191](https://togithub.com/googleapis/java-iam-admin/issues/191)) ([8302051](https://togithub.com/googleapis/java-iam-admin/commit/8302051194f258db4e3c422212e02bb536072e0b)) * Update dependency typing-extensions to v4.3.0 ([#175](https://togithub.com/googleapis/java-iam-admin/issues/175)) ([0382f2c](https://togithub.com/googleapis/java-iam-admin/commit/0382f2ccb08606b620b2f02451efecc94bec0030)) * Update dependency zipp to v3.8.1 ([#176](https://togithub.com/googleapis/java-iam-admin/issues/176)) ([e576413](https://togithub.com/googleapis/java-iam-admin/commit/e576413a97523349f01584b3d546baf64bf20456)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
…1.2.7 (#178) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-ids](https://togithub.com/googleapis/java-ids) | `1.2.6` -> `1.2.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-ids/1.2.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-ids/1.2.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-ids/1.2.7/compatibility-slim/1.2.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-ids/1.2.7/confidence-slim/1.2.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-ids). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #177.