-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a configuration checker #10761
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
70f81cd
chore: add a configuration checker
JoeWang1127 4e4fee6
format code
JoeWang1127 51ad70a
change config to test checker
JoeWang1127 5afe774
Revert "change config to test checker"
JoeWang1127 71bf0fd
Merge branch 'main' into chore/add-config-checker
JoeWang1127 9b73400
update image tag
JoeWang1127 25b3260
change docker cmd
JoeWang1127 fd681a7
Merge branch 'main' into chore/add-config-checker
JoeWang1127 473b253
change command
JoeWang1127 f814f7d
change command
JoeWang1127 9284858
change command
JoeWang1127 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,13 +30,13 @@ jobs: | |
| - name: Get current week within the year | ||
| id: date | ||
| run: echo "::set-output name=week_of_year::$(date +'%W' --utc)" | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: ${{matrix.java}} | ||
| - run: java -version | ||
| - uses: actions/cache@v3 | ||
| - uses: actions/cache@v4 | ||
| id: mvn-cache | ||
| with: | ||
| path: ~/.m2/repository | ||
|
|
@@ -50,8 +50,8 @@ jobs: | |
| steps: | ||
| - name: Support longpaths | ||
| run: git config --system core.longpaths true | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 | ||
|
|
@@ -67,13 +67,13 @@ jobs: | |
| - name: Get current week within the year | ||
| id: date | ||
| run: echo "::set-output name=week_of_year::$(date +'%W' --utc)" | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 | ||
| - run: java -version | ||
| - uses: actions/cache@v3 | ||
| - uses: actions/cache@v4 | ||
| id: mvn-cache | ||
| with: | ||
| path: ~/.m2/repository | ||
|
|
@@ -87,8 +87,8 @@ jobs: | |
| - name: Get current week within the year | ||
| id: date | ||
| run: echo "::set-output name=week_of_year::$(date +'%W' --utc)" | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 11 | ||
|
|
@@ -102,8 +102,8 @@ jobs: | |
| gapic-libraries-bom: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-java@v3 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 11 | ||
| distribution: temurin | ||
|
|
@@ -115,6 +115,23 @@ jobs: | |
| uses: googleapis/java-cloud-bom/tests/[email protected] | ||
| with: | ||
| bom-path: gapic-libraries-bom/pom.xml | ||
| generation-config-check: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: validate generation configuration | ||
| shell: bash | ||
| run: | | ||
| docker run \ | ||
| --rm \ | ||
| -u "$(id -u):$(id -g)" \ | ||
| -v "$(pwd):${workspace_name}" \ | ||
| --entrypoint python \ | ||
| gcr.io/cloud-devrel-public-resources/java-library-generation:"${library_generation_image_tag}" \ | ||
| /src/cli/entry_point.py validate-generation-config | ||
| env: | ||
| library_generation_image_tag: 2.40.0 | ||
| workspace_name: /workspace | ||
|
|
||
| # TODO: Uncomment the needed Github Actions | ||
| # dependencies: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to avoid specifying a custom entrypoint, it may be more convenient to have our docker image with
ENTRYPOINT [ 'python', '/src/cli/entry_point.py' ]instead ofENTRYPOINT [ 'python', '/src/cli/entrypoint.py', 'generate' ]. Just a nice to have