Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a configuration checker #10761

Merged
merged 11 commits into from
May 7, 2024
Merged

chore: add a configuration checker #10761

merged 11 commits into from
May 7, 2024

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Apr 29, 2024

In this PR:

  • Add a generation configuration checker in CI.

Tested the checker by changing the configuration (commit) and the check failed:

GAPICs is None in {'api_shortname': 'accessapproval', 'name_pretty': 'Access Approval', 'product_documentation': 'https://cloud.google.com/access-approval/docs/', 'api_description': "enables controlling access to your organization's data by Google personnel.", 'release_level': 'stable', 'GAPICs': None}.
Error: Process completed with exit code 1.

@JoeWang1127 JoeWang1127 closed this May 2, 2024
@JoeWang1127 JoeWang1127 reopened this May 2, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 3, 2024 16:51
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 3, 2024 16:51
-v "$(pwd):${workspace_name}" \
--entrypoint python \
gcr.io/cloud-devrel-public-resources/java-library-generation:"${library_generation_image_tag}" \
/src/cli/entry_point.py validate-generation-config
Copy link
Contributor

@diegomarquezp diegomarquezp May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to avoid specifying a custom entrypoint, it may be more convenient to have our docker image with ENTRYPOINT [ 'python', '/src/cli/entry_point.py' ] instead of ENTRYPOINT [ 'python', '/src/cli/entrypoint.py', 'generate' ]. Just a nice to have

@JoeWang1127 JoeWang1127 merged commit 24ce228 into main May 7, 2024
32 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/add-config-checker branch May 7, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants