Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we move Tuple<X, Y> from Rpc interfaces to common level? #615

Closed
mderka opened this issue Feb 3, 2016 · 4 comments
Closed

Should we move Tuple<X, Y> from Rpc interfaces to common level? #615

mderka opened this issue Feb 3, 2016 · 4 comments
Assignees
@mderka
Labels
type: question Request for information or clarification. Not an issue.

Comments

@mderka
Copy link

mderka commented Feb 3, 2016

Whenever we need to retrieve data in pages, the Rpc interface contains a nested class Tupe<X,Y> which is afaik used to associate a page token with page iterable data. It is repeated code which I found in BigQueryRpc, ProjectManagerRpc, and I am now creating another copy in DnsRpc. We should consider moving it to the core.
@mderka mderka added the type: question Request for information or clarification. Not an issue. label Feb 3, 2016
@mderka
Copy link
Author

mderka commented Feb 3, 2016

Perhaps could be done together with #613.

@ajkannan
Copy link

ajkannan commented Feb 3, 2016

It was mentioned in the discussion of #315, but we decided against adding it because we didn't want to expose a Tuple class.

@mziccard
Copy link
Contributor

mziccard commented Feb 3, 2016

I am still for not exposing it.

@mderka
Copy link
Author

mderka commented Feb 3, 2016

Ok, got it. Then we can close this.

@mderka mderka closed this as completed Feb 3, 2016
@aozarov aozarov mentioned this issue Feb 4, 2016
Merged
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@gcf-owl-bot
build(java): update renovate config to mark conformance tests as a te…
b9298a1 
…st commit type (googleapis#1199) (googleapis#615)
github-actions bot pushed a commit that referenced this issue Jun 30, 2022
@gcf-owl-bot
chore: Disable CLIRR checks on releas (#1474) (#615)
f6f1a7b 
Source-Link: googleapis/synthtool@7a220e2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mderka mderka

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mziccard @mderka @ajkannan