Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. #616

Merged
merged 4 commits into from
Feb 4, 2016
Merged

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. #616

merged 4 commits into from
Feb 4, 2016
+317 −9

Conversation

mderka
Copy link

@mderka mderka commented Feb 3, 2016

Closes #594.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2016
@mderka mderka added the api: dns Issues related to the Cloud DNS API. label Feb 3, 2016
@mderka mderka added this to the DNS Stable milestone Feb 3, 2016
@mderka mderka changed the title Completes DnsRpc interface by adding methods and doc. Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. Feb 3, 2016
@mderka
Copy link
Author

mderka commented Feb 3, 2016

DefaultDnsRpc is to be tested within integration tests in #617.

mziccard
mziccard reviewed Feb 3, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java
// just fields option
try {
return dns.managedZones().get(this.options.projectId(), zoneName)
.setFields(FIELDS.getString(options)).execute();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard
Copy link
Contributor

mziccard commented Feb 3, 2016

Not related to this PR. I think that the method Dns.getProjectInfo() should be called getProject.

@mderka
Copy link
Author

mderka commented Feb 3, 2016

Fixed all except getProject()---see above.

Regarding Dns.getProjectInfo(), I would agree if Project was functional, but it really is just a container for project quota. There are no methods that you can call on it which would contact the service. Would that not be a bit confusing?

@mderka
Copy link
Author

mderka commented Feb 4, 2016

Ok. Please, check this despite the coverall drop. See the top comment regarding tests.

aozarov
aozarov reviewed Feb 4, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/spi/DnsRpc.java
import com.google.api.services.dns.model.Project;
import com.google.api.services.dns.model.ResourceRecordSet;
import com.google.gcloud.dns.DnsException;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

aozarov
aozarov reviewed Feb 4, 2016
View reviewed changes
gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java
*/
public class DefaultDnsRpc implements DnsRpc {

private static final String SORTING_KEY = "changeSequence";

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@mziccard
Copy link
Contributor

mziccard commented Feb 4, 2016

Regarding Dns.getProjectInfo(), I would agree if Project was functional, but it really is just a container for project quota. There are no methods that you can call on it which would contact the service. Would that not be a bit confusing?

Before our most recent changes that make functional objects extend infos we used to return XXXInfo objects while the methods were called simply getXXX. I think we should stick to this convention, adding the Info suffix does not make the method clearer to me.

@mderka
Copy link
Author

mderka commented Feb 4, 2016

Re: Dns.getProjectInfo(), consistency sounds like a good enough reason. Since this touches layers above this rpc and some code that I have been working on in the mean time, I will handle it within a separate PR. Opening #619.

@mderka
Copy link
Author

mderka commented Feb 4, 2016

Ready for another check.

aozarov added a commit that referenced this pull request Feb 4, 2016
@aozarov
Merge pull request #616 from mderka/dns-options
35dbb34 
Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc.
@aozarov aozarov merged commit 35dbb34 into googleapis:dns-alpha Feb 4, 2016
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
bc85650 
…cies to v2.2.0 (googleapis#616)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.1.0` -> `2.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.2.0/compatibility-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.2.0/confidence-slim/2.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-dependencies</summary>

### [`v2.2.0`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#&#8203;220-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare210v220-2021-08-31)

[Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.1.0...v2.2.0)

##### Dependencies

-   update dependency com.fasterxml.jackson:jackson-bom to v2.12.5 ([#&googleapis#8203;456](https://www.togithub.com/googleapis/java-shared-dependencies/issues/456)) ([05b58e8](https://www.github.com/googleapis/java-shared-dependencies/commit/05b58e84ff6617bdcbb1ea644aa6e061bdea0319))
-   update dependency com.google.api:api-common to v2.0.2 ([#&googleapis#8203;450](https://www.togithub.com/googleapis/java-shared-dependencies/issues/450)) ([51caebe](https://www.github.com/googleapis/java-shared-dependencies/commit/51caebe89bfade98866f63952bf82bc663a0179a))
-   update dependency com.google.http-client:google-http-client-bom to v1.40.0 ([#&googleapis#8203;455](https://www.togithub.com/googleapis/java-shared-dependencies/issues/455)) ([82a5e42](https://www.github.com/googleapis/java-shared-dependencies/commit/82a5e42b06570a2c7c9d53b03161b110a44487a1))
-   update dependency com.google.oauth-client:google-oauth-client-bom to v1.32.1 ([#&googleapis#8203;447](https://www.togithub.com/googleapis/java-shared-dependencies/issues/447)) ([9d2b895](https://www.github.com/googleapis/java-shared-dependencies/commit/9d2b8958f62daa6a3015a8ac052762fb3d79b35b))
-   update dependency io.grpc:grpc-bom to v1.40.1 ([#&googleapis#8203;451](https://www.togithub.com/googleapis/java-shared-dependencies/issues/451)) ([df668ea](https://www.github.com/googleapis/java-shared-dependencies/commit/df668ead8830a40acf9d5605d47f93c465b779c0))
-   update gax.version to v2.4.0 ([#&googleapis#8203;458](https://www.togithub.com/googleapis/java-shared-dependencies/issues/458)) ([a797d9e](https://www.github.com/googleapis/java-shared-dependencies/commit/a797d9eb8a4bcb3025a9511eae61271278a4a5c9))
-   update google.common-protos.version to v2.5.0 ([#&googleapis#8203;457](https://www.togithub.com/googleapis/java-shared-dependencies/issues/457)) ([38c7bb9](https://www.github.com/googleapis/java-shared-dependencies/commit/38c7bb925414d90ff3065650d06589f79bcab9b6))
-   update google.core.version to v2.1.1 ([#&googleapis#8203;449](https://www.togithub.com/googleapis/java-shared-dependencies/issues/449)) ([b28723a](https://www.github.com/googleapis/java-shared-dependencies/commit/b28723ace0c27ebc73f23a2d094e0fe9ba8a9075))
-   update google.core.version to v2.1.2 ([#&googleapis#8203;459](https://www.togithub.com/googleapis/java-shared-dependencies/issues/459)) ([df4d5b7](https://www.github.com/googleapis/java-shared-dependencies/commit/df4d5b7717386f5e0e2cca87bd9afc56b2c7aee8))
-   update iam.version to v1.1.0 ([#&googleapis#8203;448](https://www.togithub.com/googleapis/java-shared-dependencies/issues/448)) ([3967928](https://www.github.com/googleapis/java-shared-dependencies/commit/39679287f3ef8c1cbca5dfc8aca3f69cfee3d4a6))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
@release-please
chore: release 1.1.0 (googleapis#614)
305c0e1 
🤖 I have created a release \*beep\* \*boop\*
---
## [1.1.0](https://www.github.com/googleapis/java-resourcemanager/compare/v1.0.4...v1.1.0) (2021-08-31)


### Features

* Remove use of deprecated gradle command in java README ([googleapis#1196](https://www.github.com/googleapis/java-resourcemanager/issues/1196)) ([googleapis#613](https://www.github.com/googleapis/java-resourcemanager/issues/613)) ([47ed387](https://www.github.com/googleapis/java-resourcemanager/commit/47ed387300dda5119aa3ecbf637eeb66077c5c93))


### Dependencies

* update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20210830-1.32.1 ([googleapis#617](https://www.github.com/googleapis/java-resourcemanager/issues/617)) ([e9743f9](https://www.github.com/googleapis/java-resourcemanager/commit/e9743f926edc076f91486879bc73cc610b012ad3))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.0 ([googleapis#616](https://www.github.com/googleapis/java-resourcemanager/issues/616)) ([bc85650](https://www.github.com/googleapis/java-resourcemanager/commit/bc8565012563e00d9054b247f5f64e6122cff69b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
@release-please
chore(main): release 2.5.0 (googleapis#616)
1af176a 
🤖 I have created a release *beep* *boop*
---


## [2.5.0](googleapis/java-monitoring-dashboards@v2.4.0...v2.5.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#611](googleapis/java-monitoring-dashboards#611)) ([7299e5e](googleapis/java-monitoring-dashboards@7299e5e))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#610](googleapis/java-monitoring-dashboards#610)) ([8a24ffb](googleapis/java-monitoring-dashboards@8a24ffb))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Nov 8, 2022
@gcf-owl-bot @chingor13
chore(java): add a note in README for migrated split repos (googleapi…
31a813d 
…s#1687) (googleapis#616)

* chore(java): add a note in README for migrated split repos

Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.

Co-authored-by: Jeff Ching <[email protected]>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mderka @mziccard @aozarov @googlebot