Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): MinExtensionPeriod defaults to 60 seconds #10791

Merged
merged 4 commits into from
Nov 12, 2024
Merged

docs(pubsub): MinExtensionPeriod defaults to 60 seconds #10791

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b613571
defaults to 60
azurda Aug 29, 2024
31a811f
update comment to clarify it is disabled
hongalex Sep 6, 2024
3fe2649
Merge branch 'main' into patch-1
hongalex Oct 24, 2024
9907bc0
Merge branch 'main' into patch-1
hongalex Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pubsub/subscription.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,8 +899,7 @@ type ReceiveSettings struct {
//
// MinExtensionPeriod must be between 10s and 600s (inclusive). This configuration
// can be disabled by specifying a duration less than (or equal to) 0.
// Defaults to off but set to 60 seconds if the subscription has exactly-once delivery enabled,
// which will be added in a future release.
// Disabled by default but set to 60 seconds if the subscription has exactly-once delivery enabled.
MinExtensionPeriod time.Duration

// MaxOutstandingMessages is the maximum number of unprocessed messages
Expand Down