Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): MinExtensionPeriod defaults to 60 seconds #10791

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

azurda
Copy link
Contributor

@azurda azurda commented Aug 29, 2024

The comment in the documentation is confusing.

From what I read through the code:

minDurationPerLeaseExtensionExactlyOnce = 1 * time.Minute
minDurationPerLeaseExtensionExactlyOnce is set to 60 seconds

and if exactlyOnce it calls maxDuration which sets it to indeed 60 s

ackDeadline = maxDuration(ackDeadline, minDurationPerLeaseExtensionExactlyOnce)

@azurda azurda requested review from shollyman and a team as code owners August 29, 2024 11:40
Copy link

conventional-commit-lint-gcf bot commented Aug 29, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@azurda azurda changed the title Documentation: MinExtensionPeriod defaults to 60 seconds docs(minDurationPerLeaseExtensionExactlyOnce): MinExtensionPeriod defaults to 60 seconds Aug 29, 2024
@codyoss codyoss changed the title docs(minDurationPerLeaseExtensionExactlyOnce): MinExtensionPeriod defaults to 60 seconds docs(pubsub): MinExtensionPeriod defaults to 60 seconds Aug 29, 2024
@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 12, 2024
@hongalex hongalex merged commit cc88fe1 into googleapis:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants