Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: many tests failed #8146

Closed
flaky-bot bot opened this issue Jun 17, 2023 · 1 comment · Fixed by #8166
Closed

spanner: many tests failed #8146

flaky-bot bot opened this issue Jun 17, 2023 · 1 comment · Fixed by #8166
Assignees
@rahul2393
Labels
api: spanner Issues related to the Spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 17, 2023

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

commit: 005d2df
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 17, 2023
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 17, 2023
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Jun 17, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 17, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (005d2df), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jun 22, 2023
@codyoss
test: fix brittle tests
ca9e916 
These tests relied on the fact that the retry option was the first.
It is likely in the future orders will change even more so these
tests should eventually be written or removed. We should exercies
that retries work more generally if we don't already.

Fixes: googleapis#8095
Fixes: googleapis#8146
@codyoss codyoss mentioned this issue Jun 22, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2023
@codyoss
test: fix brittle tests (#8166)
4a9c124 
These tests relied on the fact that the retry option was the first. It is likely in the future orders will change even more so these tests should eventually be written or removed. We should exercies that retries work more generally if we don't already.

Fixes: #8095
Fixes: #8146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the Spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix brittle tests codyoss/google-cloud-go
1 participant
@rahul2393