Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: many tests failed #8095

Closed
flaky-bot bot opened this issue Jun 14, 2023 · 17 comments · Fixed by #8166
Closed

pubsub: many tests failed #8095

flaky-bot bot opened this issue Jun 14, 2023 · 17 comments · Fixed by #8166
Assignees
@hongalex
Labels
api: pubsub Issues related to the Pub/Sub API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 14, 2023

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

commit: bd9ba3b
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 14, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jun 14, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 15, 2023

32 tests failed in this package for commit 4eb8a58 (Build Status, Sponge).

commit: 4eb8a58
buildURL: Build Status, Sponge
status: failed

@hongalex hongalex added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 15, 2023
@hongalex
Copy link
Member

There wasn't any change to the library that would correlate with these tests failing so I'm assuming they're flaky for another reason. Will continue to monitor

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 15, 2023

32 tests failed in this package for commit 24bd3a0 (Build Status, Sponge).

commit: 24bd3a0
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 15, 2023

32 tests failed in this package for commit 77ddeff (Build Status, Sponge).

commit: 77ddeff
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit 3382ef8 (Build Status, Sponge).

commit: 3382ef8
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit 28aa098 (Build Status, Sponge).

commit: 28aa098
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit 20573e2 (Build Status, Sponge).

commit: 20573e2
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit 72d0127 (Build Status, Sponge).

commit: 72d0127
buildURL: Build Status, Sponge
status: failed

@codyoss
Copy link
Member

codyoss commented Jun 16, 2023 •
edited
Loading

@hongalex I see a panic: TestClient_CustomRetry

--- FAIL: TestClient_CustomRetry (0.18s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf46a48]

goroutine 12379 [running]:
testing.tRunner.func1.2({0x1034960, 0x1859d70})
	/usr/local/go/src/testing/testing.go:1526 +0x372
testing.tRunner.func1()
	/usr/local/go/src/testing/testing.go:1529 +0x650
panic({0x1034960, 0x1859d70})
	/usr/local/go/src/runtime/panic.go:890 +0x263
cloud.google.com/go/pubsub.TestClient_CustomRetry(0xc0010dfd40)
	/tmpfs/src/google-cloud-go/pubsub/pubsub_test.go:57 +0x3c8
testing.tRunner(0xc0010dfd40, 0x11a8f20)
	/usr/local/go/src/testing/testing.go:1576 +0x217
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:1629 +0x806
FAIL	cloud.google.com/go/pubsub	140.213s

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit e43ebeb (Build Status, Sponge).

commit: e43ebeb
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2023

32 tests failed in this package for commit b429aa1 (Build Status, Sponge).

commit: b429aa1
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 17, 2023

32 tests failed in this package for commit 005d2df (Build Status, Sponge).

commit: 005d2df
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 20, 2023

32 tests failed in this package for commit b726d41 (Build Status, Sponge).

commit: b726d41
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 21, 2023

32 tests failed in this package for commit 3d1a399 (Build Status, Sponge).

commit: 3d1a399
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 21, 2023

32 tests failed in this package for commit df52820 (Build Status, Sponge).

commit: df52820
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 21, 2023

32 tests failed in this package for commit cdfd268 (Build Status, Sponge).

commit: cdfd268
buildURL: Build Status, Sponge
status: failed

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 22, 2023

32 tests failed in this package for commit 8424e7e (Build Status, Sponge).

commit: 8424e7e
buildURL: Build Status, Sponge
status: failed

codyoss added a commit to codyoss/google-cloud-go that referenced this issue Jun 22, 2023
@codyoss
test: fix brittle tests
ca9e916 
These tests relied on the fact that the retry option was the first.
It is likely in the future orders will change even more so these
tests should eventually be written or removed. We should exercies
that retries work more generally if we don't already.

Fixes: googleapis#8095
Fixes: googleapis#8146
@codyoss codyoss mentioned this issue Jun 22, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2023
@codyoss
test: fix brittle tests (#8166)
4a9c124 
These tests relied on the fact that the retry option was the first. It is likely in the future orders will change even more so these tests should eventually be written or removed. We should exercies that retries work more generally if we don't already.

Fixes: #8095
Fixes: #8146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hongalex hongalex

Labels
api: pubsub Issues related to the Pub/Sub API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix brittle tests codyoss/google-cloud-go
2 participants
@codyoss @hongalex