Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test: temporary fix for flaky test related to mocha bug" #2552

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Mar 17, 2021

Reverts #2545

@alexander-fenster fixed this!

@sofisl sofisl requested a review from a team as a code owner March 17, 2021 18:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@sofisl sofisl requested a review from JustinBeckwith March 17, 2021 18:16
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #2552 (14a896c) into master (949a89c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2552   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files          11       11           
  Lines        1841     1841           
  Branches      123      123           
=======================================
  Hits         1526     1526           
  Misses        315      315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949a89c...14a896c. Read the comment docs.

@sofisl sofisl merged commit 19bfebf into master Mar 19, 2021
@sofisl sofisl deleted the revert-2545-fixKitchenSink branch March 19, 2021 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants