Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: temporary fix for flaky test related to mocha bug #2545

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Mar 10, 2021

@sofisl sofisl requested a review from JustinBeckwith March 10, 2021 02:05
@sofisl sofisl requested a review from a team as a code owner March 10, 2021 02:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #2545 (57e776d) into master (93f4af1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files          11       11           
  Lines        1758     1758           
  Branches      123      123           
=======================================
  Hits         1500     1500           
  Misses        258      258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f4af1...57e776d. Read the comment docs.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lets maybe land this as 'test:' though, since we don't want it in the changelog.

@sofisl sofisl changed the title fix: temporary fix for flaky test related to mocha bug test: temporary fix for flaky test related to mocha bug Mar 10, 2021
@sofisl sofisl merged commit e949ef2 into master Mar 10, 2021
@sofisl sofisl deleted the fixKitchenSink branch March 10, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants