Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build for legacy targets after upgrade to .NET SDK 2.1 #1272

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

chrisdunelm
Copy link
Contributor

.NET SDK 2.1 introduces a problem when depending on packages that contain build tasks built with pre-VS2017 tooling.
This is a work-around which excludes the problematic tasks in legacy targets that are depending on older version of the support libraries.
See dotnet/msbuild#2111

I don't understand why this has only become an issue with the update to .NET SDK v2.1 from v2.0

.NET SDK 2.1 introduces a problem when depending on packages that contain build tasks built with pre-VS2017 tooling. This is a work-around which excludes the problematic tasks. See dotnet/msbuild#2111
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 21, 2018
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I understand it either, but if it works, that's fine...

@chrisdunelm chrisdunelm merged commit eab2fdf into googleapis:master Aug 21, 2018
@chrisdunelm chrisdunelm deleted the fixbuild branch August 21, 2018 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants