Skip to content

Commit

Permalink
Fix build for legacy targets after upgrade to .NET SDK 2.1 (#1272)
Browse files Browse the repository at this point in the history
.NET SDK 2.1 introduces a problem when depending on packages that contain build tasks built with pre-VS2017 tooling. This is a work-around which excludes the problematic tasks. See dotnet/msbuild#2111
  • Loading branch information
chrisdunelm authored Aug 21, 2018
1 parent 35c8e1c commit eab2fdf
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@

<PropertyGroup Condition="'$(TargetFramework)'=='netstandard1.0'">
<PackageTargetFallback>portable-net45+win8+wpa81+wp8</PackageTargetFallback>
<AutoUnifyAssemblyReferences>false</AutoUnifyAssemblyReferences>
<AppConfig>app.netstandard10.config</AppConfig>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='netstandard1.0'">
<PackageReference Include="Google.Apis" Version="[{{ features.pclSupportVersion }}]" />{% if api.authscopes %}
<PackageReference Include="Google.Apis.Auth" Version="[{{ features.pclSupportVersion }}]" />{% endif %}
<PackageReference Include="Google.Apis" Version="[{{ features.pclSupportVersion }}]" ExcludeAssets="build" />{% if api.authscopes %}
<PackageReference Include="Google.Apis.Auth" Version="[{{ features.pclSupportVersion }}]" ExcludeAssets="build" />{% endif %}
<PackageReference Include="Microsoft.NETCore.Portable.Compatibility" Version="1.0.1" />
</ItemGroup>

Expand All @@ -97,8 +96,8 @@
<AppConfig>app.net40.config</AppConfig>
</PropertyGroup>
<ItemGroup Condition="'$(TargetFramework)'=='net40'">
<PackageReference Include="Google.Apis" Version="[{{ features.net40SupportVersion }}]" />{% if api.authscopes %}
<PackageReference Include="Google.Apis.Auth" Version="[{{ features.net40SupportVersion }}]" />{% endif %}
<PackageReference Include="Google.Apis" Version="[{{ features.net40SupportVersion }}]" ExcludeAssets="build" />{% if api.authscopes %}
<PackageReference Include="Google.Apis.Auth" Version="[{{ features.net40SupportVersion }}]" ExcludeAssets="build" />{% endif %}
</ItemGroup>

</Project>

0 comments on commit eab2fdf

Please sign in to comment.