draft: Support operations for compute v2 with Reflection #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
noahdietz
reviewed
May 20, 2024
| $args = array_merge([$firstArgument], $this->additionalArgs); | ||
| $args = array_merge([$this->getName()], array_values($this->additionalArgs)); | ||
| if ($requestClass) { | ||
| $request = call_user_func_array($requestClass . '::build', $args); |
There was a problem hiding this comment.
This assumes the request class has a builder method generated from the google.api.method_signature, right?
There was a problem hiding this comment.
Yes it does! And I've confirmed all our existing Request classes have this. However, if something were introduced which didn't support this (or someone supplied the wrong Request class), this would throw a PHP Fatal Error.
it may be a good idea to add an exception here when build doesn't exist on the request class, rather than potentially throwing a PHP fatal error.
There was a problem hiding this comment.
Done in 66e4a77 (for the other PR)
|
Closing because I don't like this option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #569 which uses
ReflectionMethodinstead ofRequestclass configurationPros
Cons
ReflectionMethodto determine first argument Request classAlternatives Considered
We could add the options getRequestClass, cancelRequestClass, and deleteRequestClass to the descriptors via gapic-generator-php, which would be more efficient (no calls to ReflectionMethod) and better. See #569 and googleapis/gapic-generator-php#712