feat: support new surface operations clients #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apis/gax-php into support-operations-for-compute-v2
Co-authored-by: Noah Dietz <[email protected]>
noahdietz
approved these changes
May 29, 2024
bshaffer
changed the title
bshaffer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See googleapis/gapic-generator-php#712. Adds 3 options to the
OperationsResponseclass:$getOperationRequest$cancelOperationRequest$deleteOperationRequestThese are used to form the request to the V2 Operations client
Pros
ReflectionMethodto determine first argument Request class, which is a hackCons
longRunningdescriptorsAlternatives Considered
We could add a
ReflectionMethodto determine the request class of the Operation methods (see #570)