Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-123): disallow spaces in pattern #1293

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix(AIP-123): disallow spaces in pattern #1293

merged 1 commit into from
Dec 1, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Dec 1, 2023

Closes #1090.

@Juneezee Juneezee requested a review from a team as a code owner December 1, 2023 15:01
noahdietz
noahdietz approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noahdietz noahdietz merged commit 4d6e057 into googleapis:main Dec 1, 2023
6 checks passed
@release-please release-please bot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-123: disallow spaces in patterns
2 participants
@Juneezee @noahdietz