Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIP-123: disallow spaces in patterns #1090

Closed
noahdietz opened this issue Feb 10, 2023 · 0 comments · Fixed by #1293
Closed

AIP-123: disallow spaces in patterns #1090

noahdietz opened this issue Feb 10, 2023 · 0 comments · Fixed by #1293
Labels
good first issue priority: p2 type: bug

Comments

@noahdietz
Copy link
Collaborator

During a recent API review, I discovered that the ApiLinter either didn't run on the CL or didn't catch that a google.api.resource pattern has spaces in the value. This is not allowed per aip.dev/123, so we need to make sure we are linting for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue priority: p2 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(AIP-123): disallow spaces in pattern
1 participant
@noahdietz