Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/1617 e2e coverage for scopes #1735

Merged
merged 36 commits into from
Jul 14, 2020

Conversation

eugene-manuilov
Copy link
Collaborator

Summary

Addresses issue #1617

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@eugene-manuilov eugene-manuilov marked this pull request as ready for review July 3, 2020 16:35
Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good overall @eugene-manuilov 👍 There are just a few minor changes, suggestions, and questions for you.

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remaining comments to clean up and this should be good to go! Sorry if anything was unclear from the last review.

eugene-manuilov and others added 4 commits July 10, 2020 21:08
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
@aaemnnosttv
Copy link
Collaborator

This seems to be failing due to recent dependency changes. When you go to create a profile now, it throws this error
image
We may need to rollback this one https://github.com/focus-trap/focus-trap-react/blob/master/CHANGELOG.md where we recently updated from v5 to v7

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@aaemnnosttv
Copy link
Collaborator

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aaemnnosttv
Copy link
Collaborator

@eugene-manuilov downgrading focus-trap-react to v6 fixed the error for me locally, so I've pushed it up. If it all passes then I'll give it another review and hopefully that will be it 🙂

@eugene-manuilov
Copy link
Collaborator Author

Thanks a lot, @aaemnnosttv!

@aaemnnosttv
Copy link
Collaborator

@eugene-manuilov I added one more commit to ensure the original actions are requested after returning from oAuth as mentioned in the AC (with out this the test could pass without this happening). Should be good now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants