-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/1617 e2e coverage for scopes #1735
Enhancement/1617 e2e coverage for scopes #1735
Conversation
…ent/1617-e2e-coverage-for-scopes.
…ent/1617-e2e-coverage-for-scopes.
…to grant additional permissions.
…test to not check dashboard page.
…2e-coverage-for-scopes
…2e-coverage-for-scopes.
…2e-coverage-for-scopes.
…2e-coverage-for-scopes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good overall @eugene-manuilov 👍 There are just a few minor changes, suggestions, and questions for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remaining comments to clean up and this should be good to go! Sorry if anything was unclear from the last review.
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
Co-authored-by: Evan Mattson <[email protected]>
…2e-coverage-for-scopes.
This seems to be failing due to recent dependency changes. When you go to create a profile now, it throws this error |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@eugene-manuilov downgrading |
Thanks a lot, @aaemnnosttv! |
@eugene-manuilov I added one more commit to ensure the original actions are requested after returning from oAuth as mentioned in the AC (with out this the test could pass without this happening). Should be good now 😄 |
Summary
Addresses issue #1617
Relevant technical choices
Checklist