You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After upgrading focus-trap-react to the latest version, we faced with compatibility issue mentioned here: #1735 (comment). We need to update it to the latest version and fix that error.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
The version of focus-trap-react package used in the plugin should be upgraded to the latest major version (10.0 as of writing, but might be higher in the future)
Any errors encountered after the upgrade should be fixed.
It seems like the existing error mentioned in the screenshot here is from trying to focus-trap inside an element that is conditionally rendered or similar; this behaviour should be changed so the error is not encountered.
Implementation Brief
Update the focus-trap-react package to the latest version. (10.0.0 at the time of writing)
Using assets/js/components/Dialog.js,
Add the focusTrapOptions prop to FocusTrap with the value set to the following object:
Check that all modal dialogs render correctly, without any JS errors. For e.g for dashboard sharing settings, resetting SiteKit, asking for additional permissions, etc
Changelog entry
N/A
The text was updated successfully, but these errors were encountered:
Note : I've noticed that user role having view permission is not able to see widgets on dashboard and getting console error. Admin role user able to access widgets under view only dashboard.
This issue is related to #5772#5772 (comment) and will get resolve in related PR.
Feature Description
After upgrading focus-trap-react to the latest version, we faced with compatibility issue mentioned here: #1735 (comment). We need to update it to the latest version and fix that error.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
focus-trap-react
package used in the plugin should be upgraded to the latest major version (10.0 as of writing, but might be higher in the future)Implementation Brief
focus-trap-react
package to the latest version. (10.0.0 at the time of writing)assets/js/components/Dialog.js
,focusTrapOptions
prop toFocusTrap
with the value set to the following object:QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: