Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update focus-trap-react to the latest version and fix compatibility issues #1798

Closed
eugene-manuilov opened this issue Jul 16, 2020 · 2 comments
Labels
P2 Low priority Type: Enhancement Improvement of an existing feature

Comments

@eugene-manuilov
Copy link
Collaborator

eugene-manuilov commented Jul 16, 2020

Feature Description

After upgrading focus-trap-react to the latest version, we faced with compatibility issue mentioned here: #1735 (comment). We need to update it to the latest version and fix that error.

87339271-0aa69900-c54f-11ea-89fc-70b321c29b99


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The version of focus-trap-react package used in the plugin should be upgraded to the latest major version (10.0 as of writing, but might be higher in the future)
  • Any errors encountered after the upgrade should be fixed.
    • It seems like the existing error mentioned in the screenshot here is from trying to focus-trap inside an element that is conditionally rendered or similar; this behaviour should be changed so the error is not encountered.

Implementation Brief

QA Brief

  • Check that all modal dialogs render correctly, without any JS errors. For e.g for dashboard sharing settings, resetting SiteKit, asking for additional permissions, etc

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P2 Low priority Type: Infrastructure Engineering infrastructure & tooling labels Apr 13, 2021
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Aug 31, 2022
@asvinb asvinb assigned asvinb and unassigned asvinb Sep 14, 2022
@aaemnnosttv aaemnnosttv self-assigned this Sep 20, 2022
@aaemnnosttv
Copy link
Collaborator

IB ✅

@aaemnnosttv aaemnnosttv removed their assignment Sep 20, 2022
@aaemnnosttv aaemnnosttv added Type: Enhancement Improvement of an existing feature and removed Type: Infrastructure Engineering infrastructure & tooling labels Sep 20, 2022
@asvinb asvinb self-assigned this Sep 26, 2022
@asvinb asvinb assigned asvinb and tofumatt and unassigned asvinb Sep 26, 2022
@tofumatt tofumatt removed their assignment Sep 28, 2022
@mohitwp mohitwp self-assigned this Sep 29, 2022
@mohitwp
Copy link
Collaborator

mohitwp commented Oct 5, 2022

QA Update ✅

  • Verified on develop environment.
  • Verified dashboard sharing settings modal.
  • TwG modal for additional permissions.
  • GA4 Modal for additional permissions.
  • Disconnect and Reset Site Kit Modal.
  • All modals are rendering without any JS error.

Note : I've noticed that user role having view permission is not able to see widgets on dashboard and getting console error. Admin role user able to access widgets under view only dashboard.
This issue is related to #5772 #5772 (comment) and will get resolve in related PR.

@mohitwp mohitwp removed their assignment Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants