Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small PbList improvements #906

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Small PbList improvements #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions protobuf/lib/src/protobuf/pb_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,15 @@ class PbList<E> extends ListBase<E> {
_check = _checkNotNull;

@override
@pragma('dart2js:never-inline')
void add(E element) {
_checkModifiable('add');
_check(element);
_wrappedList.add(element);
}

@override
@pragma('dart2js:never-inline')
void addAll(Iterable<E> iterable) {
_checkModifiable('addAll');
iterable.forEach(_check);
Expand All @@ -74,6 +76,7 @@ class PbList<E> extends ListBase<E> {
}

@override
@pragma('dart2js:never-inline')
void clear() {
_checkModifiable('clear');
_wrappedList.clear();
Expand Down Expand Up @@ -163,6 +166,16 @@ class PbList<E> extends ListBase<E> {
@override
int get length => _wrappedList.length;

@override
bool get isEmpty => _wrappedList.isEmpty;

@override
bool get isNotEmpty => _wrappedList.isNotEmpty;

@override
@pragma('dart2js:never-inline')
Iterator<E> get iterator => _wrappedList.iterator;

@override
set length(int newLength) {
_checkModifiable('set length');
Expand Down
Loading