Small PbList improvements #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce binary size increase caused by cl/586928869 by adding `dart2js:never-inline` pragmas to `add`, `addAll`, `clear`. - Override `isEmpty`, `isNotEmpty` avoid virtual calls to `length`. - Override `get iterator` to use the known iterator type of `_wrappedList`, which is always a `_GrowableList`. cl/587627017
That CL in itself is just making types more precise. If this leads to a size increase, it's because the dart2js inlining heuristics decided it's worthwhile inlining. @rakudrama are the heuristics in dart2js doing the right thing here? |
mkustermann
approved these changes
Dec 5, 2023
|
@mkustermann see b/314275739 for discussion on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce binary size increase caused by cl/586928869 by adding
dart2js:never-inlinepragmas toadd,addAll,clear.Override
isEmpty,isNotEmptyavoid virtual calls tolength.Override
get iteratorto use the known iterator type of_wrappedList, which is always a_GrowableList.cl/587627017