Fix code block token count #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 90.64% 90.75% +0.10%
==========================================
Files 11 11
Lines 2373 2400 +27
Branches 2373 2400 +27
==========================================
+ Hits 2151 2178 +27
Misses 159 159
Partials 63 63 ☔ View full report in Codecov by Sentry. |
kdarkhan
reviewed
Jan 24, 2024
i18n-helpers/src/lib.rs
Outdated
| @@ -569,12 +569,22 @@ fn check_code_block_token_count(group: &[(usize, Event)]) -> usize { | |||
| let events = group.iter().map(|(_, event)| event); | |||
| let mut in_codeblock = false; | |||
| let mut max_token_count = 0; | |||
|
|
|||
| // token_count should be taken over Text events | |||
| // because a continuous text may be splitted to some Text events. | |||
There was a problem hiding this comment.
Nit: If this is about splitting a single text into several Text events, then several instead of some might be more accurate in this context.
kdarkhan
approved these changes
Jan 24, 2024
kdarkhan
reviewed
Jan 24, 2024
dalance
force-pushed
the
fix_codeblock_token_count
branch
from
4f3b869
to
dbff4ca
Compare
|
@kdarkhan Thank you for your review. I've fixed the comment and |
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes wrong token count in code block reported at #150.