-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
group_events
fuzz test is flaky
#150
Comments
I've opened a PR to fix the existing token couting code. I agree pulldown-cmark-to-cmark should construct an appropriate markdown without workaround. |
Awesome, thank you very much! I see the discussion here: Byron/pulldown-cmark-to-cmark#20 (comment) and that you've opened Byron/pulldown-cmark-to-cmark#65 to fix it. Thanks also for #153 — I'm happy to merge that and then simplify our code when the fix has been released in the upstream pulldown-cmark-to-cmark crate. |
I let it run for a few million iterations on my desktop and it looks rock solid now! Fixed by #153. |
After #129, the
group_events
fuzz test seems to have become flaky. @dalance, would you be able to take a look?An example failure is here, where the failing input can be minimized to
The diff of the failure is
meaning that
reconstruct_markdown(&events, None)
returnedwhereas
reconstruct_markdown(&flattened_groups, None)
returnedMy guess is that this is because the counting of consequetive
`
is slightly off.Indeed, looking at
flattened_groups
in the fuzz test, I seewith lots of lone
`
characters.A related question, is this not something which should be fixed in pulldown-cmark-to-cmark instead of here? @dalance, could you create an issue in that repository and see if you can move the fix from here to there?
The text was updated successfully, but these errors were encountered: