Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: update go.mod #2027

Merged
merged 2 commits into from
May 8, 2019
Merged

all: update go.mod #2027

merged 2 commits into from
May 8, 2019

Conversation

eliben
Copy link
Member

@eliben eliben commented May 8, 2019

Following the fix of #1958, we can remove the vault requirement in go.mod. For this PR:

  • Removed vault from go.mod
  • Reran go test ./..., and the go tool updated go.mod

@googlebot googlebot added the cla: yes Google CLA has been signed! label May 8, 2019
@eliben eliben requested a review from vangent May 8, 2019 20:59
@eliben eliben requested a review from shantuo May 8, 2019 20:59
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #2027 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2027      +/-   ##
==========================================
- Coverage   77.54%   77.52%   -0.03%     
==========================================
  Files          82       82              
  Lines        9671     9671              
==========================================
- Hits         7499     7497       -2     
- Misses       1630     1632       +2     
  Partials      542      542
Impacted Files Coverage Δ
pubsub/kafkapubsub/kafka.go 83.45% <0%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1aed6...97142a2. Read the comment docs.

@vangent
Copy link
Contributor

vangent commented May 8, 2019

Tests failed:

FAIL: dependencies changed; run: internal/testing/listdeps.sh > internal/testing/alldeps

@eliben
Copy link
Member Author

eliben commented May 8, 2019

Tests failed:

FAIL: dependencies changed; run: internal/testing/listdeps.sh > internal/testing/alldeps

Yes, rerunning tests now. vault masked a bunch of packages it seems, so now they explicitly appear in go list, not sure why... but they all are used by vault/api. Maybe a general refactoring of their packages

@eliben eliben merged commit 74dfb2d into google:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA has been signed!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants