Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secrets/vault: stop depending on Vault root module in test #1958

Closed
zombiezen opened this issue Apr 30, 2019 · 5 comments · Fixed by #1983
Closed

secrets/vault: stop depending on Vault root module in test #1958

zombiezen opened this issue Apr 30, 2019 · 5 comments · Fixed by #1983
Labels
bug Something isn't working code health Code health task, either refactoring or testing

Comments

@zombiezen
Copy link
Contributor

Describe the bug

Our integration test spins up a Vault instance by linking in the code and running it in-process AFAICT. Vault recently split their repository into submodules: github.com/hashicorp/vault, github.com/hashicorp/vault/api, and github.com/hashicorp/vault/sdk. However, they have not released a version of the vault top-level module that excludes the api packages. This causes ambiguous import errors during builds.

To Reproduce

  1. Run go mod tidy in gocloud.dev/
  2. Run internal/testing/listdeps.sh

Expected behavior

A list of dependencies is printed to stdout.

Actual behavior

The following error message occurs:

build gocloud.dev/samples/gocdk-secrets: cannot load github.com/hashicorp/vault/api: ambiguous import: found github.com/hashicorp/vault/api in multiple modules:
        github.com/hashicorp/vault v1.1.2 (/home/light/pkg/mod/github.com/hashicorp/[email protected]/api)
        github.com/hashicorp/vault/api v1.0.1 (/home/light/pkg/mod/github.com/hashicorp/vault/[email protected])

Version

gocloud.dev master (a5a281f)

Additional context

We have been near-missing this because up to this point, we haven't imported anything that specified a module requirement on github.com/hashicorp/vault/api. Running go mod tidy appears to be grabbing everything from Vault tests, which then includes github.com/hashicorp/vault/helper/builtinplugins, which seems like a big offender of bringing in more stuff.

This is a known issue reported (and closed as WAI) upstream: hashicorp/vault#6634

@zombiezen zombiezen added bug Something isn't working code health Code health task, either refactoring or testing labels Apr 30, 2019
@eliben
Copy link
Member

eliben commented May 1, 2019

Yikes. This seems to interfere with work on #886 because I'll need to run the equivalent of go mod tidy in the "new" contrib/secrets/vault place.

@zombiezen
Copy link
Contributor Author

Yeah, this isn't great. I think we should fix it sooner rather than later, because it feels like a landmine.

@eliben
Copy link
Member

eliben commented May 2, 2019

Any ideas for a fix? In a separate experiment it seems that go mod gets confused about usage of vault in general now for code that both imports the main path and api

@zombiezen
Copy link
Contributor Author

My proposed solution is to run Vault from a Docker container like how we're handling other dependencies rather than trying to link it in (i.e. remove the main Vault module dependency).

@shantuo
Copy link
Contributor

shantuo commented May 2, 2019

There also needs to be some change on the makeHarness of the vault tests as we'll need to do some more setup to use the vault binary instead of the test server IIRC. I can take a look at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code health Code health task, either refactoring or testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants