Fixes various model loading timing issues when loading multiple captures. #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When selecting a command at a point in the trace where all shaders have been created, then opening/capturing another trace, will cause the shader view to stop updating itself, unless a command is selected in the (new) trace before all shaders were created. Fixes google#1195 Fixes google#1309
The timeline model did not reset itself when opening a new capture, but delayed the reset until the contexts were loaded. This caused the filmstrip to be in a bad state in the time between the new capture being loaded and the contexts of the new capture being loaded. At best this caused the old thumbnails to re-appear and at worst an error dialog, if the selection would be out of bounds in the new capture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a command at a point in the trace where all shaders have been created, then opening/capturing another trace, will cause the shader view to stop updating itself, unless a command is selected in the (new) trace before all shaders were created.
The timeline model did not reset itself when opening a new capture, but delayed the reset until the contexts were loaded. This caused the filmstrip to be in a bad state in the time between the new capture being loaded and the contexts of the new capture being loaded. At best this caused the old thumbnails to re-appear and at worst an error dialog, if the selection would be out of bounds in the new capture.