Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gapic: Band-aids for widget dispose errors and null states. #1328

Closed
wants to merge 1 commit into from
Closed

gapic: Band-aids for widget dispose errors and null states. #1328

wants to merge 1 commit into from

Conversation

ben-clayton
Copy link
Contributor

Not sure if this is the right way to fix these issues, but there seem to be plenty of ways to cause these exceptions when going monkeying with GVR apps.

@ben-clayton
gapic: Band-aids for widget dispose errors and null states.
1edfed2 
Not sure if this is the right way to fix these issues, but there seem to be plenty of ways to cause these exceptions when going monkeying with GVR apps.
@ben-clayton
Copy link
Contributor Author

Fixes #1303

@pmuetschard
Copy link
Member

I prefer my #1334 over this to fix the disposed widget issue, because it limits the disposal check to the RPC->UI boundary.

The null state, I believe is fixed by #1331.

@ben-clayton ben-clayton closed this Nov 4, 2017
@ben-clayton ben-clayton deleted the gapic-bandaids branch November 4, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuetschard pmuetschard Awaiting requested review from pmuetschard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-clayton @pmuetschard