Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UngroupedOverloads: ignore generated constructors #3632

Closed
wants to merge 1 commit into from
Closed

UngroupedOverloads: ignore generated constructors #3632

wants to merge 1 commit into from

Conversation

Stephan202
Copy link
Contributor

Fixes #3404.

Stephan202
Stephan202 commented Dec 29, 2022
View reviewed changes
core/src/main/java/com/google/errorprone/bugpatterns/UngroupedOverloads.java
Comment on lines +99 to +101
if (!ASTHelpers.isGeneratedConstructor(methodTree)) {
methods.put(OverloadKey.create(methodTree), MemberWithIndex.create(i, methodTree));
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check matches the constraint that otherwise triggers the IllegalArgumentException reported in #3404. As these generated constructors are invisible, it makes sense (I suppose) that UngroupedOverloads shouldn't care about their location.

@Stephan202 Stephan202 mentioned this pull request Dec 29, 2022
Closed
gijskant
gijskant approved these changes Dec 30, 2022
View reviewed changes
Copy link

@gijskant gijskant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue and is nicely covered by a test.

Stephan202 added a commit to PicnicSupermarket/error-prone that referenced this pull request Dec 31, 2022
@Stephan202
UngroupedOverloads: ignore generated constructors
fc81ded 
See google#3632.
@Stephan202
Copy link
Contributor Author

Rebased (so that the build passes also on JDK 20-ea). Would be nice to include this change in the next Error Prone release, as it seems to impact quite some JDK 16+ users.

copybara-service bot pushed a commit that referenced this pull request Dec 31, 2022
@java-team-github-bot
UngroupedOverloads: ignore generated constructors
db35b6f 
Fixes #3404.

Fixes #3632

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3632 from PicnicSupermarket:bugfix/issue-3404 897aa79
PiperOrigin-RevId: 498732782
@copybara-service copybara-service bot mentioned this pull request Dec 31, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Dec 31, 2022
@java-team-github-bot
UngroupedOverloads: ignore generated constructors
65fc697 
Fixes #3404.

Fixes #3632

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3632 from PicnicSupermarket:bugfix/issue-3404 897aa79
PiperOrigin-RevId: 498732782
benkard pushed a commit to benkard/jgvariant that referenced this pull request Jan 14, 2023
Update all non-major dependencies (mulk/jgvariant!22)
d1cd814 
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://github.com/google/error-prone)) |  | minor | `2.16` -> `2.18.0` |
| [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | compile | minor | `2.16` -> `2.18.0` |
| [org.apache.maven.plugins:maven-failsafe-plugin](https://maven.apache.org/surefire/) | build | patch | `3.0.0-M7` -> `3.0.0-M8` |
| [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | build | patch | `3.0.0-M7` -> `3.0.0-M8` |

---

### Release Notes

<details>
<summary>google/error-prone</summary>

### [`v2.18.0`](https://github.com/google/error-prone/releases/tag/v2.18.0): Error Prone 2.18.0

[Compare Source](google/error-prone@v2.17.0...v2.18.0)

New Checkers:

-   [`InjectOnBugCheckers`](https://errorprone.info/bugpattern/InjectOnBugCheckers)
-   [`LabelledBreakTarget`](https://errorprone.info/bugpattern/LabelledBreakTarget)
-   [`UnusedLabel`](https://errorprone.info/bugpattern/UnusedLabel)
-   [`YodaCondition`](https://errorprone.info/bugpattern/YodaCondition)

Fixes issues: [#&#8203;1650](google/error-prone#1650), [#&#8203;2706](google/error-prone#2706), [#&#8203;3404](google/error-prone#3404), [#&#8203;3493](google/error-prone#3493), [#&#8203;3504](google/error-prone#3504), [#&#8203;3519](google/error-prone#3519), [#&#8203;3579](google/error-prone#3579), [#&#8203;3610](google/error-prone#3610), [#&#8203;3632](google/error-prone#3632), [#&#8203;3638](google/error-prone#3638), [#&#8203;3645](google/error-prone#3645), [#&#8203;3646](google/error-prone#3646), [#&#8203;3652](google/error-prone#3652), [#&#8203;3690](google/error-prone#3690)

**Full Changelog**: google/error-prone@v2.17.0...v2.18.0

### [`v2.17.0`](https://github.com/google/error-prone/releases/tag/v2.17.0): Error Prone 2.17.0

[Compare Source](google/error-prone@v2.16...v2.17.0)

New Checkers:

-   [`AvoidObjectArrays`](https://errorprone.info/bugpattern/AvoidObjectArrays)
-   [`Finalize`](https://errorprone.info/bugpattern/Finalize)
-   [`IgnoredPureGetter`](https://errorprone.info/bugpattern/IgnoredPureGetter)
-   [`ImpossibleNullComparison`](https://errorprone.info/bugpattern/ProtoFieldNullComparison)
-   [`MathAbsoluteNegative`](https://errorprone.info/bugpattern/MathAbsoluteNegative)
-   [`NewFileSystem`](https://errorprone.info/bugpattern/NewFileSystem)
-   [`StatementSwitchToExpressionSwitch`](https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch)
-   [`UnqualifiedYield`](https://errorprone.info/bugpattern/UnqualifiedYield)

Fixed issues: [#&#8203;2321](google/error-prone#2321), [#&#8203;3144](google/error-prone#3144), [#&#8203;3297](google/error-prone#3297), [#&#8203;3428](google/error-prone#3428), [#&#8203;3437](google/error-prone#3437), [#&#8203;3462](google/error-prone#3462), [#&#8203;3482](google/error-prone#3482), [#&#8203;3494](google/error-prone#3494)

**Full Changelog**: google/error-prone@v2.16...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
@Stephan202 Stephan202 deleted the bugfix/issue-3404 branch February 6, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@gijskant gijskant gijskant approved these changes

@cushon cushon cushon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalArgumentException: Cannot edit synthetic AST nodes with specific record constructor
4 participants
@Stephan202 @cushon @gijskant @rickie