Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnusedMethod: Add more JPA lifecycle annotations or make annotations configurable #3297

Closed
jnehlmeier opened this issue Jun 28, 2022 · 3 comments
Closed

UnusedMethod: Add more JPA lifecycle annotations or make annotations configurable #3297

jnehlmeier opened this issue Jun 28, 2022 · 3 comments

Comments

@jnehlmeier
Copy link

Currently UnusedMethod only ignores JPA lifecycle annotation javax.persistence.PostLoad.

However there are quite a few more:

  • PostLoad
  • PostPersist
  • PostRemove
  • PostUpdate
  • PrePersist
  • PreRemove
  • PreUpdate

Also with the move to Jakarta namespace, all these annotations should be added with javax.persistence as well as jakarta.persistence package.
rickie added a commit to PicnicSupermarket/error-prone that referenced this issue Sep 2, 2022
@rickie
UnusedMethod: Support additional exempting method annotations
10fcb9c 
Fixes google#3144 & google#3297
@rickie rickie mentioned this issue Sep 2, 2022
Closed
rickie added a commit to PicnicSupermarket/error-prone that referenced this issue Sep 26, 2022
@rickie
UnusedMethod: Support additional exempting method annotations
a5d36e3 
Fixes google#3144 & google#3297
@reitzmichnicht
Copy link

Now with spring boot 3 available this issue is a bit annoying. Any estimate if this will be included in the next error prone release?

@Stephan202
Copy link
Contributor

@rickie opened PR #3428 for this; I see that @cushon and @graememorgan worked on UnusedMethod before; maybe one of them can give it a push. :)

Agree this would be nice to see improved!

rickie added a commit to PicnicSupermarket/error-prone that referenced this issue Dec 15, 2022
@rickie
UnusedMethod: Support additional exempting method annotations
bdf40fc 
Fixes google#3144 & google#3297
@copybara-service copybara-service bot mentioned this issue Dec 19, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Dec 19, 2022
@graememorgan
UnusedMethod: Support additional exempting method annotations
324780d 
Fixes #3144 & #3297.

Fixes #3428

FUTURE_COPYBARA_INTEGRATE_REVIEW=#3428 from PicnicSupermarket:rossendrijver/unusedmethod_improvements 99f8878
PiperOrigin-RevId: 495640502
copybara-service bot pushed a commit that referenced this issue Dec 19, 2022
@rickie
UnusedMethod: Support additional exempting method annotations
ac0bbb0 
Fixes #3144 & #3297.

Fixes #3428

COPYBARA_INTEGRATE_REVIEW=#3428 from PicnicSupermarket:rossendrijver/unusedmethod_improvements 99f8878
PiperOrigin-RevId: 496348968
@rickie
Copy link
Contributor

rickie commented Dec 21, 2022

The PR #3428 is now merged, so we can close this ticket 😄.

@cushon cushon closed this as completed Dec 21, 2022
benkard pushed a commit to benkard/jgvariant that referenced this issue Jan 14, 2023
Update all non-major dependencies (mulk/jgvariant!22)
d1cd814 
This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://github.com/google/error-prone)) |  | minor | `2.16` -> `2.18.0` |
| [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | compile | minor | `2.16` -> `2.18.0` |
| [org.apache.maven.plugins:maven-failsafe-plugin](https://maven.apache.org/surefire/) | build | patch | `3.0.0-M7` -> `3.0.0-M8` |
| [org.apache.maven.plugins:maven-surefire-plugin](https://maven.apache.org/surefire/) | build | patch | `3.0.0-M7` -> `3.0.0-M8` |

---

### Release Notes

<details>
<summary>google/error-prone</summary>

### [`v2.18.0`](https://github.com/google/error-prone/releases/tag/v2.18.0): Error Prone 2.18.0

[Compare Source](google/error-prone@v2.17.0...v2.18.0)

New Checkers:

-   [`InjectOnBugCheckers`](https://errorprone.info/bugpattern/InjectOnBugCheckers)
-   [`LabelledBreakTarget`](https://errorprone.info/bugpattern/LabelledBreakTarget)
-   [`UnusedLabel`](https://errorprone.info/bugpattern/UnusedLabel)
-   [`YodaCondition`](https://errorprone.info/bugpattern/YodaCondition)

Fixes issues: [#&#8203;1650](google/error-prone#1650), [#&#8203;2706](google/error-prone#2706), [#&#8203;3404](google/error-prone#3404), [#&#8203;3493](google/error-prone#3493), [#&#8203;3504](google/error-prone#3504), [#&#8203;3519](google/error-prone#3519), [#&#8203;3579](google/error-prone#3579), [#&#8203;3610](google/error-prone#3610), [#&#8203;3632](google/error-prone#3632), [#&#8203;3638](google/error-prone#3638), [#&#8203;3645](google/error-prone#3645), [#&#8203;3646](google/error-prone#3646), [#&#8203;3652](google/error-prone#3652), [#&#8203;3690](google/error-prone#3690)

**Full Changelog**: google/error-prone@v2.17.0...v2.18.0

### [`v2.17.0`](https://github.com/google/error-prone/releases/tag/v2.17.0): Error Prone 2.17.0

[Compare Source](google/error-prone@v2.16...v2.17.0)

New Checkers:

-   [`AvoidObjectArrays`](https://errorprone.info/bugpattern/AvoidObjectArrays)
-   [`Finalize`](https://errorprone.info/bugpattern/Finalize)
-   [`IgnoredPureGetter`](https://errorprone.info/bugpattern/IgnoredPureGetter)
-   [`ImpossibleNullComparison`](https://errorprone.info/bugpattern/ProtoFieldNullComparison)
-   [`MathAbsoluteNegative`](https://errorprone.info/bugpattern/MathAbsoluteNegative)
-   [`NewFileSystem`](https://errorprone.info/bugpattern/NewFileSystem)
-   [`StatementSwitchToExpressionSwitch`](https://errorprone.info/bugpattern/StatementSwitchToExpressionSwitch)
-   [`UnqualifiedYield`](https://errorprone.info/bugpattern/UnqualifiedYield)

Fixed issues: [#&#8203;2321](google/error-prone#2321), [#&#8203;3144](google/error-prone#3144), [#&#8203;3297](google/error-prone#3297), [#&#8203;3428](google/error-prone#3428), [#&#8203;3437](google/error-prone#3437), [#&#8203;3462](google/error-prone#3462), [#&#8203;3482](google/error-prone#3482), [#&#8203;3494](google/error-prone#3494)

**Full Changelog**: google/error-prone@v2.16...v2.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cushon @Stephan202 @jnehlmeier @reitzmichnicht @rickie