Introduce command-line flag -XepAllSuggestionsAsWarnings
#3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
We have a bunch of SUGGESTION-level bug checkers internally (to be open sourced "soon" ™️), flagging things that aren't objectively warnings in all contexts. So this feature would be very helpful to us. :)
I verified against some internal code that the new flag works as intended.
hisener
approved these changes
Jul 1, 2022
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Aug 4, 2022
rickie
changed the title
-Xep:AllSuggestionsAsWarnings-XepAllSuggestionsAsWarnings
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
3061fad to
f654914
Compare
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
f654914 to
84da046
Compare
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Oct 12, 2022
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Oct 13, 2022
For completeness: those bug checkers are now open sourced as part of Error Prone Support. We're already using |
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
84da046 to
85442e0
Compare
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
85442e0 to
8ed0de3
Compare
|
Rebased and resolved conflict. |
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
8ed0de3 to
7f96b49
Compare
|
Rebased and resolved conflict. Would still be great if this could be added in Error Prone 😄. |
Stephan202
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
7f96b49 to
a0cdc7d
Compare
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Dec 31, 2022
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
Jan 9, 2023
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
May 10, 2023
Stephan202
pushed a commit
to PicnicSupermarket/error-prone
that referenced
this pull request
May 10, 2023
rickie
force-pushed
the
rossendrijver/suggestions_as_warnings
branch
from
a0cdc7d to
5cd3aa1
Compare
cushon
approved these changes
Jun 7, 2023
benkard
pushed a commit
to benkard/jgvariant
that referenced
this pull request
Jun 18, 2023
This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.google.errorprone:error_prone_core](https://errorprone.info) ([source](https://github.com/google/error-prone)) | | minor | `2.19.1` -> `2.20.0` | | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://github.com/google/error-prone)) | compile | minor | `2.19.1` -> `2.20.0` | --- ### Release Notes <details> <summary>google/error-prone</summary> ### [`v2.20.0`](https://github.com/google/error-prone/releases/tag/v2.20.0): Error Prone 2.20.0 [Compare Source](google/error-prone@v2.19.1...v2.20.0) Changes: - This release is compatible with early-access builds of JDK 21. New Checkers: - [`InlineTrivialConstant`](https://errorprone.info/bugpattern/InlineTrivialConstant) - [`UnnecessaryStringBuilder`](https://errorprone.info/bugpattern/UnnecessaryStringBuilder) - [`BanClassLoader`](https://errorprone.info/bugpattern/BanClassLoader) - [`DereferenceWithNullBranch`](https://errorprone.info/bugpattern/DereferenceWithNullBranch) - [`DoNotUseRuleChain`](https://errorprone.info/bugpattern/DoNotUseRuleChain) - [`LockOnNonEnclosingClassLiteral`](https://errorprone.info/bugpattern/LockOnNonEnclosingClassLiteral) - [`MissingRefasterAnnotation`](https://errorprone.info/bugpattern/MissingRefasterAnnotation) - [`NamedLikeContextualKeyword`](https://errorprone.info/bugpattern/NamedLikeContextualKeyword) - [`NonApiType`](https://errorprone.info/bugpattern/NonApiType) Fixes issues: [#​2232](google/error-prone#2232), [#​2243](google/error-prone#2243), [#​2997](google/error-prone#2997), [#​3301](google/error-prone#3301), [#​3843](google/error-prone#3843), [#​3903](google/error-prone#3903), [#​3918](google/error-prone#3918), [#​3923](google/error-prone#3923), [#​3931](google/error-prone#3931), [#​3945](google/error-prone#3945), [#​3946](google/error-prone#3946) **Full Changelog**: google/error-prone@v2.19.1...v2.20.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users that build with
-Werrorto disallow violations of customSUGGESTION-level bug patterns.