Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce command-line flag -XepAllSuggestionsAsWarnings #33

Closed
wants to merge 1 commit into from
Closed

Introduce command-line flag -XepAllSuggestionsAsWarnings #33

wants to merge 1 commit into from

Conversation

rickie
Copy link
Member

@rickie rickie commented Jun 17, 2022

There appear to be quite some code changes, but only a few lines are really changing behavior, see the ScannerSupplier and associated test in ScannerSupplierTest.

The code largely mimics the behavior of the XepAllDisabledChecksAsWarnings flag.

Perhaps the test should be more complicated, but that isn't as easy as it looks. Let's discuss that offline if necessary 😄.

@rickie rickie requested a review from Stephan202 June 17, 2022 17:34
@rickie rickie mentioned this pull request Jun 17, 2022
Closed
@Stephan202 Stephan202 force-pushed the rossendrijver/suggestions_as_warnings branch from 985094f to 02981ae Compare June 25, 2022 17:32
Stephan202
Stephan202 reviewed Jun 25, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a small commit. Tested that it works :)

Suggested commit message:

Introduce command-line flag `-XepAllSuggestionsAsWarnings`

This enables users that build with `-Werror` to disallow violations of custom
`SUGGESTION`-level bug patterns.

@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from 02981ae to 3061fad Compare June 29, 2022 14:31
@rickie
Copy link
Member Author

rickie commented Jun 29, 2022 •
edited
Loading

Opened google#3301.

@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from 3061fad to f654914 Compare August 8, 2022 07:01
@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from f654914 to 84da046 Compare September 2, 2022 07:56
@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from 84da046 to 85442e0 Compare October 24, 2022 08:12
@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from 85442e0 to 8ed0de3 Compare November 18, 2022 13:17
@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from 8ed0de3 to 7f96b49 Compare December 27, 2022 19:37
@Stephan202 Stephan202 force-pushed the rossendrijver/suggestions_as_warnings branch from 7f96b49 to a0cdc7d Compare December 31, 2022 10:04
@philleonard philleonard mentioned this pull request Jun 2, 2023
Merged
@rickie rickie force-pushed the rossendrijver/suggestions_as_warnings branch from a0cdc7d to 5cd3aa1 Compare June 7, 2023 16:55
@rickie
Copy link
Member Author

rickie commented Jul 11, 2023

Upstream PR is merged 🥳.

@rickie rickie closed this Jul 11, 2023
@rickie rickie deleted the rossendrijver/suggestions_as_warnings branch July 11, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickie @Stephan202