fix: move delete keyboard shortcut in-progress gesture check to precondition #6274

[humera811]

The basics

• I validated my changes

The details

Resolves

• Fixes Move delete keyboard shortcut in-progress gesture check to precondition #6274: Move delete keyboard shortcut in-progress gesture check to precondition

Proposed Changes

• Add a check to the precondition function to make sure a gesture is not in progress.
• Remove the gesture check

Reason for Changes

-The delete keyboard shortcut was checking if there is a gesture in progress from within its callback function, and returns early if so which should not have been the case

Test Coverage

Documentation

Additional Information

• issue Move delete keyboard shortcut in-progress gesture check to precondition #6274

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[conventional-commit-lint-gcf]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

[github-actions]

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

• You can find tips about contributing to Blockly and how to
  validate your changes on our
  developer site.

• All contributors must sign the Google Contributor License
  Agreement (CLA). If the google-cla bot leaves a comment on this
  PR, make sure you follow the instructions.

• We use conventional commits
  to make versioning the package easier. Make sure your commit
  message is in the proper format
  or learn how to fix it.

• If any of the other checks on this PR fail, you can click on
  them to learn why. It might be that your change caused a test
  failure, or that you need to double-check the
  style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

[debaraj-barua]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

@humera811 To fix this, you could either change the commit message using:

 git commit --amend -m "fix #6274: Move delete keyboard shortcut in-progress gesture check to precondition" 
 git push --force origin fixes

or any message you feel is appropriate

or just add the automerge label as suggested

Additionally, in your PR description, under

Resolves

    Fixes Move delete keyboard shortcut in-progress gesture check to precondition

you could also add a link to the issue like

Resolves

    Fixes #6274: Move delete keyboard shortcut in-progress gesture check to precondition

That should auto-link this PR to the issue.

[rachel-fenichel]

🎉 Thanks for contributing!