fix: remove old render method
#7308
Conversation
BeksOmega
force-pushed
the
fix/remove-render
branch
from
8103cca
to
1d8425c
Compare
BeksOmega
force-pushed
the
fix/remove-render
branch
from
1d8425c
to
5587ee1
Compare
BeksOmega
force-pushed
the
fix/remove-render
branch
from
5587ee1
to
97148ea
Compare
| this.toolbox_.position(); | ||
| } | ||
| } else { | ||
| if (!isVisible) { |
There was a problem hiding this comment.
Why is this one not needed? Setting the workspace visibility doesn't directly change the blocks or fields, so no rerender would be triggered.
Put another way: what case was this handling before?
There was a problem hiding this comment.
I have no idea what case this was handling before. But I can't think of a reason it's needed now! I manually tested showing and hiding the workspace, and everything looks correct.
There was a problem hiding this comment.
Dug into the blame, and the render existed originally when setVisible was implemented.: e8ab929 So maybe itw as necessary at some point? Or maybe it was just added cautiously.
I tested adding block to the workspace while the workspace was hidden, and that also works and renders things correctly. So I think this is safe to remove!
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Removes the last vestiges of the old render management system.
Reason for Changes
Less variants!
Test Coverage
All tests pass. Smoke tested the playground and it looks good!
Also tested that hiding and showing the workspace works properly.
Documentation
N/A
Additional Information
Dependent on #7306 and #7307