-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: disabling/enabling blocks not consitent #7113
Comments
Hi @maribethb, |
I can only reproduce this in XML, not in JSON. The advanced playground uses XML for its save capabilities so that's why you can reproduce it there but not by loading JSON in the regular simple playground. I wrote a test case for xml equivalent to the json test case I wrote in #7172 and can confirm it fails. Guess I should have written that at the time too. I confirmed this bug was also present in XML in Blockly v9.3.1 so I'm not sure why I thought it wasn't when I fixed this for XML. I did notice it wasn't present in XML in 9.1.1 however. @mrkprdo are you serializing in json or xml in your app? You provided json for the reproduction steps above, but if you're still experiencing this in your app, is it with xml? I can't repro with JSON at all right now. |
@maribethb that's right, i am serializing in xml. |
When you call
other note: the fix in #7172 was effectively removed in #7308 so investigating that. adding it back to the in json, it works because so I think our options are |
Check for duplicates
Description
if one of the inner block is disabled, and then you disabled few blocks on the top.
saving the json/xml and loading it again, if you enable the top level block it does not get enabled, but the context menu has already changed to "disable block", you have to disable and enable it again to work with the block.
Reproduction steps
The only thing that has been done here, is the getter block forasd
is disabled before disabling the entire blocks.Stack trace
No response
Screenshots
Browsers
No response
The text was updated successfully, but these errors were encountered: