Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: refactor warning icon #7112

Merged
merged 14 commits into from
Jun 2, 2023
Merged

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented May 22, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #7040

Proposed Changes

Refactors the warning icon to conform to the IIcon interface.

Reason for Changes

Code unification!

Test Coverage

N/A

Documentation

N/A

Additional Information

Dependent on #7110

Best to review commit-wise! If I need to split this up further just lmk.

Breaking changes / updating / upgrading

If you were previously modifying the warning icon directly, that is no longer available. Modifying warnings should be done through the setWarningText method on the block. E.g:

myBlock.setWarningText('some new warning text', 'an ID');

Deprecations

Showing/hiding bubbles

If you need to modify whether the bubble of the warning icon is visible or not, you can do:

myBlock.getIcon(Blockly.icons.WarningIcon.TYPE).setBubbleVisible(true);

The setVisible method will be removed in v11.


If you have another use case that is not covered here, please file a feature request so we can work to find a solution for you =)

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels May 22, 2023
@BeksOmega BeksOmega force-pushed the feat/warning-icon branch 2 times, most recently from e3acde4 to 7e63bc1 Compare May 22, 2023 20:52
core/icons/warning_icon.ts Outdated Show resolved Hide resolved
@BeksOmega BeksOmega force-pushed the feat/warning-icon branch from 7e63bc1 to 3dae016 Compare May 24, 2023 20:02
@BeksOmega BeksOmega marked this pull request as ready for review May 24, 2023 20:21
@BeksOmega BeksOmega requested a review from a team as a code owner May 24, 2023 20:21
@BeksOmega BeksOmega requested a review from NeilFraser May 24, 2023 20:21
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels May 24, 2023
core/icons/warning_icon.ts Outdated Show resolved Hide resolved
core/icons/warning_icon.ts Outdated Show resolved Hide resolved
@BeksOmega BeksOmega mentioned this pull request Jun 1, 2023
4 tasks
@BeksOmega BeksOmega force-pushed the feat/warning-icon branch from 8063db2 to e71c897 Compare June 1, 2023 13:42
@BeksOmega BeksOmega force-pushed the feat/warning-icon branch from 219a1ed to 505d368 Compare June 2, 2023 16:16
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jun 2, 2023
@BeksOmega BeksOmega merged commit f4e378d into google:develop Jun 2, 2023
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jun 2, 2023
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jun 27, 2023
@maribethb maribethb mentioned this pull request Aug 10, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the Warning icon to conform to the IIcon interface
2 participants