-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: refactor warning icon #7112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3acde4
to
7e63bc1
Compare
BeksOmega
commented
May 22, 2023
BeksOmega
commented
May 22, 2023
BeksOmega
commented
May 22, 2023
7e63bc1
to
3dae016
Compare
BeksOmega
commented
May 25, 2023
NeilFraser
approved these changes
May 31, 2023
8063db2
to
e71c897
Compare
219a1ed
to
505d368
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #7040
Proposed Changes
Refactors the warning icon to conform to the
IIcon
interface.Reason for Changes
Code unification!
Test Coverage
N/A
Documentation
N/A
Additional Information
Dependent on #7110
Best to review commit-wise! If I need to split this up further just lmk.
Breaking changes / updating / upgrading
If you were previously modifying the warning icon directly, that is no longer available. Modifying warnings should be done through the
setWarningText
method on the block. E.g:Deprecations
Showing/hiding bubbles
If you need to modify whether the bubble of the warning icon is visible or not, you can do:
The
setVisible
method will be removed in v11.If you have another use case that is not covered here, please file a feature request so we can work to find a solution for you =)